diff mbox series

[net-next] ice: fix an error code in ice_ena_vfs()

Message ID 20211013080012.GB6010@kili
State Accepted
Delegated to: Anthony Nguyen
Headers show
Series [net-next] ice: fix an error code in ice_ena_vfs() | expand

Commit Message

Dan Carpenter Oct. 13, 2021, 8 a.m. UTC 
Return the error code if ice_eswitch_configure() fails.  Don't return
success.

Fixes: 1c54c839935b ("ice: enable/disable switchdev when managing VFs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Simon Horman Oct. 14, 2021, 9:05 a.m. UTC | #1 
On Wed, Oct 13, 2021 at 11:00:12AM +0300, Dan Carpenter wrote:
> Return the error code if ice_eswitch_configure() fails.  Don't return
> success.
> 
> Fixes: 1c54c839935b ("ice: enable/disable switchdev when managing VFs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 4d0b643906ff..2bd783ec685c 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -1975,7 +1975,8 @@  static int ice_ena_vfs(struct ice_pf *pf, u16 num_vfs)
 
 	clear_bit(ICE_VF_DIS, pf->state);
 
-	if (ice_eswitch_configure(pf))
+	ret = ice_eswitch_configure(pf);
+	if (ret)
 		goto err_unroll_sriov;
 
 	return 0;