| Message ID | 20210223121923.1503421-1-sasha.neftin@intel.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v1,1/1] igc: Remove no need includes from igc_mac.h | expand |
On Tue, 2021-02-23 at 14:19 +0200, Sasha Neftin wrote: > igc_defines.h and igc_phy.h included in igc_hw.h > Therefore no need to include these headers in igc_mac.h > where is include igc_hw.h From the submit-checklist, we don't want to be relying on other files' includes. If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use. https://www.kernel.org/doc/Documentation/process/submit-checklist.rst Though we aren't perfect in this, we shouldn't be removing this as it's desired. Thanks, Tony
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.h b/drivers/net/ethernet/intel/igc/igc_mac.h index b5963f86defb..04d0cadfa3d6 100644 --- a/drivers/net/ethernet/intel/igc/igc_mac.h +++ b/drivers/net/ethernet/intel/igc/igc_mac.h @@ -5,8 +5,6 @@ #define _IGC_MAC_H_ #include "igc_hw.h" -#include "igc_phy.h" -#include "igc_defines.h" /* forward declaration */ s32 igc_disable_pcie_master(struct igc_hw *hw);
igc_defines.h and igc_phy.h included in igc_hw.h Therefore no need to include these headers in igc_mac.h where is include igc_hw.h Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> --- drivers/net/ethernet/intel/igc/igc_mac.h | 2 -- 1 file changed, 2 deletions(-)