| Message ID | 20200917201347.81570-8-anthony.l.nguyen@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [S53,01/15] virtchnl: Use pad byte in virtchnl_ether_addr to specify MAC type | expand |
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Tony > Nguyen > Sent: Thursday, September 17, 2020 1:14 PM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH S53 08/15] ice: don't always return an error for > Get PHY Abilities AQ command > > From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> > > There are times when the driver shouldn't return an error when the Get > PHY abilities AQ command (0x0600) returns an error. Instead the driver > should log that the error occurred and continue on. This allows the > driver to load even though the AQ command failed. The user can then > later determine the reason for the failure and correct it. > > Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Aaron Brown <aaron.f.brown@intel.com>
diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index 1aee8d5791a7..a0cf60272aab 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -925,7 +925,7 @@ enum ice_status ice_init_hw(struct ice_hw *hw) ICE_AQC_REPORT_TOPO_CAP, pcaps, NULL); devm_kfree(ice_hw_to_dev(hw), pcaps); if (status) - goto err_unroll_sched; + ice_debug(hw, ICE_DBG_PHY, "Get PHY capabilities failed, continuing anyway\n"); /* Initialize port_info struct with link information */ status = ice_aq_get_link_info(hw->port_info, false, NULL, NULL);