diff mbox series

[v1,1/1] e1000e: Fix typo in Alder Lake brand name

Message ID 20200217060718.20965-1-sasha.neftin@intel.com
State Superseded
Delegated to: Jeff Kirsher
Headers show
Series [v1,1/1] e1000e: Fix typo in Alder Lake brand name | expand

Commit Message

Sasha Neftin Feb. 17, 2020, 6:07 a.m. UTC 
Follow to commit e15ef7697361 ("e1000e: Add support for Alder Lake")
Fix typo in brand name string

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/e1000e/hw.h     | 8 ++++----
 drivers/net/ethernet/intel/e1000e/netdev.c | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Jesse Brandeburg Feb. 18, 2020, 5:45 p.m. UTC | #1 
On Mon, 17 Feb 2020 08:07:18 +0200 Sasha wrote:
> -#define E1000_DEV_ID_PCH_ADP_1219_LM16		0x1A1E
                                ^
                                ^^^
Man this change is so subtle, you should definitely mention in your
commit message that you're changing a "one" to an "I"

I wrote a whole response to this mail without seeing the difference
until the end.
Sasha Neftin Feb. 19, 2020, 6:38 a.m. UTC | #2 
On 2/18/2020 19:45, Jesse Brandeburg wrote:
> On Mon, 17 Feb 2020 08:07:18 +0200 Sasha wrote:
>> -#define E1000_DEV_ID_PCH_ADP_1219_LM16		0x1A1E
>                                  ^
>                                  ^^^
> Man this change is so subtle, you should definitely mention in your
> commit message that you're changing a "one" to an "I"
> 
> I wrote a whole response to this mail without seeing the difference
> until the end.
> 
I will send v2 and mention the change.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
index 61a0c7cb9ced..b1447221669e 100644
--- a/drivers/net/ethernet/intel/e1000e/hw.h
+++ b/drivers/net/ethernet/intel/e1000e/hw.h
@@ -98,10 +98,10 @@  struct e1000_hw;
 #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
 #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
 #define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5
-#define E1000_DEV_ID_PCH_ADP_1219_LM16		0x1A1E
-#define E1000_DEV_ID_PCH_ADP_1219_V16		0x1A1F
-#define E1000_DEV_ID_PCH_ADP_1219_LM17		0x1A1C
-#define E1000_DEV_ID_PCH_ADP_1219_V17		0x1A1D
+#define E1000_DEV_ID_PCH_ADP_I219_LM16		0x1A1E
+#define E1000_DEV_ID_PCH_ADP_I219_V16		0x1A1F
+#define E1000_DEV_ID_PCH_ADP_I219_LM17		0x1A1C
+#define E1000_DEV_ID_PCH_ADP_I219_V17		0x1A1D
 
 #define E1000_REVISION_4	4
 
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 35f21add3732..fb92002cabee 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7763,10 +7763,10 @@  static const struct pci_device_id e1000_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V14), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM15), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V15), board_pch_cnp },
-	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_1219_LM16), board_pch_cnp },
-	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_1219_V16), board_pch_cnp },
-	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_1219_LM17), board_pch_cnp },
-	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_1219_V17), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_LM16), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_V16), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_LM17), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_V17), board_pch_cnp },
 
 	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
 };