mbox series

[net-next,0/3] Cleanup intel driver declarations

Message ID 20240903122234.964218-1-yuehaibing@huawei.com
Headers show
Series Cleanup intel driver declarations | expand

Message

Yue Haibing Sept. 3, 2024, 12:22 p.m. UTC
Yue Haibing (3):
  iavf: Remove unused declarations
  igb: Cleanup unused declarations
  ice: Cleanup unused declarations

 drivers/net/ethernet/intel/iavf/iavf.h           | 10 ----------
 drivers/net/ethernet/intel/iavf/iavf_prototype.h |  3 ---
 drivers/net/ethernet/intel/ice/ice_eswitch.h     |  5 -----
 drivers/net/ethernet/intel/ice/ice_flex_pipe.h   |  3 ---
 drivers/net/ethernet/intel/ice/ice_lib.h         |  2 --
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h      |  3 ---
 drivers/net/ethernet/intel/ice/ice_txrx_lib.h    |  1 -
 drivers/net/ethernet/intel/igb/e1000_mac.h       |  1 -
 drivers/net/ethernet/intel/igb/e1000_nvm.h       |  1 -
 9 files changed, 29 deletions(-)

Comments

Maciej Fijalkowski Sept. 3, 2024, 12:35 p.m. UTC | #1
Hi Yue,

I know these patches are obvious but one sentence in cover letter
wouldn't hurt 😊

Anyways, for the content:
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> Yue Haibing (3):
>   iavf: Remove unused declarations
>   igb: Cleanup unused declarations
>   ice: Cleanup unused declarations
> 
>  drivers/net/ethernet/intel/iavf/iavf.h           | 10 ----------
>  drivers/net/ethernet/intel/iavf/iavf_prototype.h |  3 ---
>  drivers/net/ethernet/intel/ice/ice_eswitch.h     |  5 -----
>  drivers/net/ethernet/intel/ice/ice_flex_pipe.h   |  3 ---
>  drivers/net/ethernet/intel/ice/ice_lib.h         |  2 --
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h      |  3 ---
>  drivers/net/ethernet/intel/ice/ice_txrx_lib.h    |  1 -
>  drivers/net/ethernet/intel/igb/e1000_mac.h       |  1 -
>  drivers/net/ethernet/intel/igb/e1000_nvm.h       |  1 -
>  9 files changed, 29 deletions(-)
> 
> --
> 2.34.1
>
Keller, Jacob E Sept. 3, 2024, 9:18 p.m. UTC | #2
On 9/3/2024 5:22 AM, Yue Haibing wrote:
> 
> Yue Haibing (3):
>   iavf: Remove unused declarations
>   igb: Cleanup unused declarations
>   ice: Cleanup unused declarations
> 

It would be interesting to see when the code for these declarations was
removed (if it was ever present in the kernel to begin with?)