mbox series

[iwl-next,0/7] ice: refactor and cleanup control queue logic

Message ID 20240806-e810-live-migration-rd32-poll-timeout-v1-0-b5ada29ce703@intel.com
Headers show
Series ice: refactor and cleanup control queue logic | expand

Message

Keller, Jacob E Aug. 6, 2024, 8:46 p.m. UTC 
This series includes several minor improvements and refactors to the
control queue logic.

Jacob implements and uses rd32_poll_timeout to replace a jiffies loop for
calling ice_sq_done. The rd32_poll_timeout() function is designed to allow
simplifying other places in the driver where we need to read a register
until it matches a known value.

Jacob, Bruce, and Przemek update ice_debug_cq() to be more robust, and more
useful for tracing control queue messages sent and received by the device
driver.

Jacob rewords several commands in the ice_control.c file which previously
referred to the "Admin queue" when they were actually generic functions
usable on any control queue.

Jacob removes the unused and unnecessary cmd_buf array allocation for send
queues. This logic originally was going to be useful if we ever implemented
asynchronous completion of transmit messages. This support is unlikely to
materialize, so the overhead of allocating a command buffer is unnecessary.

Sergey improves the log messages when the ice driver reports that the NVM
version on the device is not supported by the driver. Now, these messages
include both the discovered NVM version and the requested/expected NVM
version.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Bruce Allan (1):
      ice: do not clutter debug logs with unused data

Jacob Keller (4):
      ice: implement and use rd32_poll_timeout for ice_sq_done timeout
      ice: improve debug print for control queue messages
      ice: reword comments referring to control queues
      ice: remove unnecessary control queue cmd_buf arrays

Przemek Kitszel (1):
      ice: stop intermixing AQ commands/responses debug dumps

Sergey Temerkhanov (1):
      ice: Report NVM version numbers on mismatch during load

 drivers/net/ethernet/intel/ice/ice_adminq_cmd.h |   4 +
 drivers/net/ethernet/intel/ice/ice_controlq.h   |   5 +-
 drivers/net/ethernet/intel/ice/ice_osdep.h      |  28 ++--
 drivers/net/ethernet/intel/ice/ice_controlq.c   | 176 +++++++++++++-----------
 4 files changed, 116 insertions(+), 97 deletions(-)
---
base-commit: 10a6545f0bdcbb920c6a8a033fe342111d204915
change-id: 20240805-e810-live-migration-rd32-poll-timeout-218ae6443beb

Best regards,