mbox series

[iwl-next,v6,0/4] Support rx-fcs on/off for VFs

Message ID 20230905185020.3613223-1-ahmed.zaki@intel.com
Headers show
Series Support rx-fcs on/off for VFs | expand

Message

Ahmed Zaki Sept. 5, 2023, 6:50 p.m. UTC 
Allow the user to turn on/off the CRC/FCS stripping through ethtool. We
first add the CRC offload capability in the virtchannel, then the feature
is enabled in ice and iavf drivers.

We make sure that the netdev features are fixed such that CRC stripping
cannot be disabled if VLAN rx offload (VLAN strip) is enabled. Also, VLAN
stripping cannot be enabled unless CRC stripping is ON.
---
v6: Some code was mistakenly included in v5 (4/4), sorry for spamming.
v5: Remove extra space in ice_for_each_alloc_rxq()  (3/4)
v4: Use ice_for_each_alloc_rxq in ice_vsi_is_rxq_crc_strip_dis()  (3/4)
v3: Fix Tony's comments in ice_vf_init_vlan_stripping() (3/4)
v2: Move patch "ice: Fix VLAN and CRC strip co-existence" from 4/4 to 3/4
    Other minor fixes from Tony for the same patch

Haiyue Wang (2):
  ice: Support FCS/CRC strip disable for VF
  ice: Fix VLAN and CRC strip co-existence

Norbert Zulinski (1):
  iavf: Add ability to turn off CRC stripping for VF

Paul M Stillwell Jr (1):
  virtchnl: Add CRC stripping capability

 drivers/net/ethernet/intel/iavf/iavf.h        |  2 +
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 59 +++++++++++++++-
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  4 ++
 drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  3 +
 drivers/net/ethernet/intel/ice/ice_virtchnl.c | 69 +++++++++++++++++--
 include/linux/avf/virtchnl.h                  | 11 ++-
 6 files changed, 141 insertions(+), 7 deletions(-)

Comments

Paul Menzel Sept. 6, 2023, 3:59 a.m. UTC | #1 
Dear Ahmed,


Thank you for submitting this work.

Am 05.09.23 um 20:50 schrieb Ahmed Zaki:
> Allow the user to turn on/off the CRC/FCS stripping through ethtool. We
> first add the CRC offload capability in the virtchannel, then the feature
> is enabled in ice and iavf drivers.
> 
> We make sure that the netdev features are fixed such that CRC stripping
> cannot be disabled if VLAN rx offload (VLAN strip) is enabled. Also, VLAN
> stripping cannot be enabled unless CRC stripping is ON.

Please add a paragraph, how you tested this.


Kind regards,

Paul


> ---
> v6: Some code was mistakenly included in v5 (4/4), sorry for spamming.
> v5: Remove extra space in ice_for_each_alloc_rxq()  (3/4)
> v4: Use ice_for_each_alloc_rxq in ice_vsi_is_rxq_crc_strip_dis()  (3/4)
> v3: Fix Tony's comments in ice_vf_init_vlan_stripping() (3/4)
> v2: Move patch "ice: Fix VLAN and CRC strip co-existence" from 4/4 to 3/4
>      Other minor fixes from Tony for the same patch
> 
> Haiyue Wang (2):
>    ice: Support FCS/CRC strip disable for VF
>    ice: Fix VLAN and CRC strip co-existence
> 
> Norbert Zulinski (1):
>    iavf: Add ability to turn off CRC stripping for VF
> 
> Paul M Stillwell Jr (1):
>    virtchnl: Add CRC stripping capability
> 
>   drivers/net/ethernet/intel/iavf/iavf.h        |  2 +
>   drivers/net/ethernet/intel/iavf/iavf_main.c   | 59 +++++++++++++++-
>   .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  4 ++
>   drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  3 +
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c | 69 +++++++++++++++++--
>   include/linux/avf/virtchnl.h                  | 11 ++-
>   6 files changed, 141 insertions(+), 7 deletions(-)
>