From patchwork Sat Aug 19 13:50:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zulkifli, Muhammad Husaini" X-Patchwork-Id: 1823301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=jNiUkNbe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RSgCm1wrcz1yfT for ; Sat, 19 Aug 2023 23:52:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5359E838CC; Sat, 19 Aug 2023 13:52:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5359E838CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692453136; bh=Eu3FW2lvrnsAnJidlav939XcYlTYylRC2P5Alb8lWTM=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=jNiUkNbe8h91n4TADWnyvWAxiNH50DCQjQAuX6c3FoZ1/U5Ogt8PiJlQEJTtLu64Q vZ4m4E3eBFyCv2Ijxtx5g9r+24uwjdamxp6HYhuljQoyrgmiBhNIeX7hf02PXyajtj 3rKEZja06aE7aBdS44CG2/Emk2nPWoN0MAL4YmIMVB+ieRqZSBhq+OQdexKtYLfVdE mNINQ8y63TGAvTs/hbp5/PTSMgJiu72RuC5itRCFe0Vzw8a6SZTdQEmnzNNIhnPwzF qGfH8LH3AWqVcfVt/2S3vnR4E4EXQDR+2oSpb9mRspRyj4pwCaHyg5GSvyisUOTtAN xUHHGS40D/OsQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tFrMKtU3Pj6o; Sat, 19 Aug 2023 13:52:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 3554A83BD7; Sat, 19 Aug 2023 13:52:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3554A83BD7 X-Original-To: intel-wired-lan@osuosl.org Delivered-To: intel-wired-lan@osuosl.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1F3671BF476 for ; Sat, 19 Aug 2023 13:52:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id ED59683BA1 for ; Sat, 19 Aug 2023 13:52:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED59683BA1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WjnsA1CcCkZA for ; Sat, 19 Aug 2023 13:52:12 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by smtp1.osuosl.org (Postfix) with ESMTPS id A9C24838CC for ; Sat, 19 Aug 2023 13:52:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A9C24838CC X-IronPort-AV: E=McAfee;i="6600,9927,10807"; a="363463618" X-IronPort-AV: E=Sophos;i="6.01,186,1684825200"; d="scan'208";a="363463618" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2023 06:52:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10807"; a="805452173" X-IronPort-AV: E=Sophos;i="6.01,186,1684825200"; d="scan'208";a="805452173" Received: from zulkifl3-ilbpg0.png.intel.com ([10.88.229.82]) by fmsmga004.fm.intel.com with ESMTP; 19 Aug 2023 06:52:08 -0700 From: Muhammad Husaini Zulkifli To: intel-wired-lan@osuosl.org Date: Sat, 19 Aug 2023 21:50:49 +0800 Message-Id: <20230819135051.29390-1-muhammad.husaini.zulkifli@intel.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692453132; x=1723989132; h=from:to:cc:subject:date:message-id; bh=LgBTQjLoGAIGJfx4euGq4bhsXXYEwJRUIPf9oNcVRj0=; b=kjfukgZaug8ZbIf6L17uA3OMZ7rrOsKevGpSRiPrGApwPUUnsIuEo1cK 3QUogSiOZaXHxIu8V67Mgw3YcL4SCvx8l0Zwrnd/o3Gtf+Gch46kPXmhf Nu0tsONll1qgM/WntQk8/sUc1Nl1jA7ad+ybtBdBJ6j4DSKtzkOtMUhDe r9gKFKuyQ0voC6PiTCXEHyUKE1sy6OKczYmXVtVGOv4aHLqyDqoD+oFwT n/2kkinigRDl/VicGOrrvuDFj9JLh33SWln1I5KLd0TEOMb2EkM2bBnRJ pdVKUE9H8l60pEcfcY7pURCyiipk6drTWZ4JVzTWW4YKXDzAcDUeHoyBT w==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=kjfukgZa Subject: [Intel-wired-lan] [PATCH iwl-net v4 0/2] Enhance the tx-usecs coalesce setting implementation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bcreeley@amd.com, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, anthony.l.nguyen@intel.com, horms@kernel.org, kuba@kernel.org, davem@davemloft.net MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" The current tx-usecs coalesce setting implementation in the driver code is improved by this patch series. The implementation of the current driver code may have previously been a copy of the legacy code i210. Patch 1: Allow the user to see the tx-usecs coalesce setting's current value when using the ethtool command. The previous value was 0. Patch 2: Give the user the ability to modify the tx-usecs coalesce setting's value. Previously, it was restricted to rx-usecs. V3 -> V4: - Implement the helper function, as recommended by Brett Creely. - Fix typo in cover letter. V2 -> V3: - Refactor the code, as Simon suggested, to make it more readable. V1 -> V2: - Split the patch file into two, like Anthony suggested. Muhammad Husaini Zulkifli (2): igc: Expose tx-usecs coalesce setting to user igc: Modify the tx-usecs coalesce setting drivers/net/ethernet/intel/igc/igc_ethtool.c | 58 +++++++++++++------- 1 file changed, 37 insertions(+), 21 deletions(-) --- 2.17.1