mbox series

[net,v2,0/2] Fix VF to VM attach detach

Message ID 20230809151529.842798-1-poros@redhat.com
Headers show
Series Fix VF to VM attach detach | expand

Message

Petr Oros Aug. 9, 2023, 3:15 p.m. UTC 
v2: fixed typos in the description of the second patch

v1: https://lore.kernel.org/netdev/20230807094831.696626-1-poros@redhat.com/

Petr Oros (2):
  Revert "ice: Fix ice VF reset during iavf initialization"
  ice: Fix NULL pointer deref during VF reset

 drivers/net/ethernet/intel/ice/ice_sriov.c    |  8 ++---
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 34 +++++--------------
 drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 -
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |  1 -
 4 files changed, 12 insertions(+), 32 deletions(-)

Comments

Przemek Kitszel Aug. 10, 2023, 12:52 p.m. UTC | #1 
On 8/9/23 17:15, Petr Oros wrote:
> v2: fixed typos in the description of the second patch
> 
> v1: https://lore.kernel.org/netdev/20230807094831.696626-1-poros@redhat.com/
> 
> Petr Oros (2):
>    Revert "ice: Fix ice VF reset during iavf initialization"
>    ice: Fix NULL pointer deref during VF reset
> 
>   drivers/net/ethernet/intel/ice/ice_sriov.c    |  8 ++---
>   drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 34 +++++--------------
>   drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 -
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |  1 -
>   4 files changed, 12 insertions(+), 32 deletions(-)
> 

You have forgot to propagate reviewed-by tags from v1 (Simon's, Jake's, 
mine)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

(I'm not sure if I should copy-paste not mine RBs here?)
Jakub Kicinski Aug. 10, 2023, 3:51 p.m. UTC | #2 
On Thu, 10 Aug 2023 14:52:33 +0200 Przemek Kitszel wrote:
> You have forgot to propagate reviewed-by tags from v1 (Simon's, Jake's, 
> mine)
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> 
> (I'm not sure if I should copy-paste not mine RBs here?)

Not 100% sure either but most of the time I reckon it'd be a good thing.
Higher probability that we may miss a tag than that the person intended
to withdraw it. Just make sure the person who's tag you're copying is
on CC and that you add a link to where the tag was provided.