From patchwork Tue Feb 28 16:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 1749520 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=SBUrLiHM; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PR3G46gz1z1yX2 for ; Wed, 1 Mar 2023 03:48:12 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4726C811FA; Tue, 28 Feb 2023 16:48:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4726C811FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1677602891; bh=Gp57vdH7B6FsHme+d63j0TcVL5gXR234ZK4r1bfo3xI=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=SBUrLiHMhnDj0fFE3XXvwfKC5oc9WxR3l8gEpRetKY1hzcXcOpnFCepEtqJ39ta/r RrnrAMso9L2UYlg/eD5AILQNgacuA/o5y88kgjXiObKHHni84qzuVogUWNqvvPI7/7 FKMDPCBISMUqVGHB+lKzEV3aE6SdtUkWqH630AlNtrN+x41DtkXTsNdQIT3a6YpiA7 SEGcrJXrwlCazBcqLVdiX2udroVWGd4QkP0cSe+BgD0la58DxZzQgiWL7muU35O7zm m4DKAOzLTXFTSiBvT87USUOXzqVJ3V0PwnpkJI/KoKc+qKnHYice4EAF05A2nLhPtV TxJG9aNluQIxg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id niZzwRgEcZB1; Tue, 28 Feb 2023 16:48:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 329C181207; Tue, 28 Feb 2023 16:48:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 329C181207 X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1742B1BF5A8 for ; Tue, 28 Feb 2023 16:48:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AB57F60E83 for ; Tue, 28 Feb 2023 16:48:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AB57F60E83 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tmP4A9KXWWsY for ; Tue, 28 Feb 2023 16:48:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D5D92607E1 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by smtp3.osuosl.org (Postfix) with ESMTPS id D5D92607E1 for ; Tue, 28 Feb 2023 16:48:06 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="317986831" X-IronPort-AV: E=Sophos;i="5.98,222,1673942400"; d="scan'208";a="317986831" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 08:48:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="624107465" X-IronPort-AV: E=Sophos;i="5.98,222,1673942400"; d="scan'208";a="624107465" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2023 08:48:03 -0800 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 07A41369ED; Tue, 28 Feb 2023 16:48:01 +0000 (GMT) From: Alexander Lobakin To: Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Date: Tue, 28 Feb 2023 17:46:11 +0100 Message-Id: <20230228164613.1360409-1-aleksander.lobakin@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677602886; x=1709138886; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WRHLtls8wXHkKG0wPUdAzJHiEECJD6P2u5mrgkq32og=; b=GIITSovHGRKPNNTtFu04OQGPMroln0wHW/qqp0zCw8RKm17eppp+CFws /PUYx1LkfG9HzeeORUnfDR2tB0YnNvcsKjlmd14wsubbFTadTjxdS7klW n9oTsrlgL7i41IbRyNU/A/K9xeXlMmTy0OYlHv7BMZ6gJv8uWL21EvvBD icJ+BV2gcU7tlii29k/2gyfhtaBBsiOXwQFzoX5TjPuuTTEtHfHF+7jdi SaK0GFNAczUaWQbkh0/rKSVg/0JeN1s8xl4Cbdtcxfz3v5LaZoV4aNw2v FThPn5cmwovc4gLUJYnb07o152pMgB0iYdhnmie0jWGd+/5Gbs6tGEKlF Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GIITSovH Subject: [Intel-wired-lan] [PATCH net 0/2] iavf: fix double-broken HW hash report X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Larysa Zaremba , netdev@vger.kernel.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Michal Kubiak , intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Currently, passing HW hash from descriptors to skb is broken two times. The first bug effectively disables hash from being filled at all, unless %NETIF_F_RXHASH is *disabled* via Ethtool. The second incorrectly says that IPv6 UDP packets are L3, which also triggers CPU hashing when needed (the networking core treats only L4 HW hash as "true"). The very same problems were fixed in i40e and ice, but not in iavf, although each of the original commits bugged at least two drivers. It's never too late (I hope), so fix iavf this time. Alexander Lobakin (2): iavf: fix inverted Rx hash condition leading to disabled hash iavf: fix non-tunneled IPv6 UDP packet type and hashing drivers/net/ethernet/intel/iavf/iavf_common.c | 2 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- To Tony: this is very trivial and tested for a while already, I hope it could hit one of the first couple RCs :p