From patchwork Thu Aug 15 18:49:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Smith X-Patchwork-Id: 1972880 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fpdXdVDr; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ezurio.com header.i=@ezurio.com header.a=rsa-sha256 header.s=selector1 header.b=dcLlqBLu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WlDhz5DF2z1yXZ for ; Fri, 16 Aug 2024 04:50:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mcfzzNYYhkln8UOdGp5oSceubiM3ZeDlbHDWUQU9dQw=; b=fpdXdVDrjGDXFf cO3JK44INzS/OqzGD15u8jS+kBlbcgeRdn9Z28396z6AGF2r2BrZoOCr1TfYraUjfahz7J6akP3+z 3RI6fbu4B3dSruyds5te7ADO3EftsXU/JjDYwE6xEZOOv2EMO32BU3+e9wVyyWEMqtwU6tf4+r9fL XmX00+j+6xdpVMVxH/phZwWCIxHZCW32YvHNelf2fOcxUySUZhxS6PotUVEbk7tsdA3b5G/++QU0S Eu2hwz7ubO/0fSquNuytzd2x1EbFHcxPgJvkaXLPyMyvUideGB1hYBO8tUAalavFPyVan/y+WQYnT F3wLN/61EfXwxVEQpSPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sefXx-0000000AoUv-1uYl; Thu, 15 Aug 2024 18:50:05 +0000 Received: from mail-dm6nam12on20728.outbound.protection.outlook.com ([2a01:111:f403:2417::728] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sefXs-0000000AoU0-1aOm for hostap@lists.infradead.org; Thu, 15 Aug 2024 18:50:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AU9D1qHLzsmjeYmibyf1Jkjt5JK50Qd13nvmAPYxpFKgQj6mVdbegM6bKd2eSs0yt8p/KhY3eNHoA/mvJ000jWUt5qiJ1VXg9MFB5L/DMWVfQrIADMGhuKv9vBKbqrWmofeSgomMCQMTIqfkf0SuUn5JIZ1v2Noi8xTbJtKUjbmF6hnDfQo+yQUsQqzwv0E24tcPScjrjKrTX4gvv1NNFj8Y7XEEVK7r7HavTzRuP1WnWRCZuL4O0Frvp8PVb6GTO8NuLams9o2o1dUydpH0U4c42P9KtVSJnSHQAoVSvpkhj1SMziXLXk2Zw6dSBH9AgT0KCO6bKrfnn9QoCXvxzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QvIzZ6MlQ38ulHB7fFzvDW2D4/vKripi9JK6xsHyiic=; b=k/qf+sQKSHNmCgScBf/pHFVWyPjI0QaVUuVZVIkc8cqT4LxY+90xz3cZDXRrLbpEhs9VtnOi7XjqhfmHnGbCp2HUsp4jmBz/cKTtCyEpSxbHYG7KMNtD+2pOglvO3SaEtWUEQcsDTlsJY89rvgqIFG82WozcHSIBLMIJTpzlcUk0Uf7gQvLZe6O4F25qOPmsF1NhDrbk/m+2QMo3QcqefD4OygaNHKd2auVvGDPLiwhgCU33sTVJdTZQqRK4gX9J94WKhPlYoiSiibffRoEEyXw59rnlkxf+sWmj7AnY3t5BL6yJtZ3XP2Kg3eSPBypDSdfLY6z0RcbvIsXi52BYAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ezurio.com; dmarc=pass action=none header.from=ezurio.com; dkim=pass header.d=ezurio.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ezurio.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvIzZ6MlQ38ulHB7fFzvDW2D4/vKripi9JK6xsHyiic=; b=dcLlqBLudGt0bygN+1sDGB7pr3eQYgQdD8q9lLhUAMzYrcuOKZKPGbJeazMuMAMCbXp4M6F7qttKUlYygfZalXtQk3as5qxHC81EkJzKSTzpFxV7BmtE19H0u9RssIszriwF4TGvkiDpjtwy8irjPiasIFbqHsXmNw8zTVp2b63hmje45R6Jzy94Yq5m9quwC9Mk7PNOz3/x+LpXQbLNXwTZEokndIY4kuLeg4M8gPUDAJCJjg4Ub+VApmmddK3VOwxe9HecNCNsA4HAh/cWA6HGN2tDGLHArxYhdNarvSvJ/c6T2HHwnXaARtkVZwgy9oQPa7EVErc88zNVYzG93g== Received: from PH7PR14MB5713.namprd14.prod.outlook.com (2603:10b6:510:213::19) by PH0PR14MB6634.namprd14.prod.outlook.com (2603:10b6:510:2a2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Thu, 15 Aug 2024 18:49:51 +0000 Received: from PH7PR14MB5713.namprd14.prod.outlook.com ([fe80::c8ab:ae07:13df:825d]) by PH7PR14MB5713.namprd14.prod.outlook.com ([fe80::c8ab:ae07:13df:825d%4]) with mapi id 15.20.7849.021; Thu, 15 Aug 2024 18:49:51 +0000 From: Doug Smith To: "hostap@lists.infradead.org" Subject: wpa_supplicant 2.11 - thick-mac open AP won't pass data packets Thread-Topic: wpa_supplicant 2.11 - thick-mac open AP won't pass data packets Thread-Index: AQHa7z6dG6NFf3ze4UKveOXst1p7mA== Date: Thu, 15 Aug 2024 18:49:51 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ezurio.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR14MB5713:EE_|PH0PR14MB6634:EE_ x-ms-office365-filtering-correlation-id: a505c72a-5af6-45c5-3566-08dcbd5b0b7b x-ms-exchange-atpmessageproperties: SA x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?JMiJOF18km1lCXzhNnWMTabZiI?= =?iso-8859-1?q?ck5nysfNPradBiVPTf/UR8eGr0Vt3oOUsuHQKxrbGOtTFHjrj6xHBD90qnVT?= =?iso-8859-1?q?ivxm1ADxnp7tu/zw5rF/1atckX3Yc/K96I+SIrjrRbFamVr4ED1y0f5fcmQo?= =?iso-8859-1?q?T7qZK7JgpBITL43Nog3WKDQWx5ZjCtwUJ4wc6nyegGgMMRQS3tzDjXlHfrWs?= =?iso-8859-1?q?H8nQOyyWOH6CyyEasu679wJXlz/ZS//Bbf5ITqFr/OQ5cl6SJfrzYcgYW8+S?= =?iso-8859-1?q?2ZPnh4s2FgC3hGkII29iAX+mv1v7L66akBCk4S4AfMjwfsvYsJbswTvabWrk?= =?iso-8859-1?q?yjFHpdEhY4j0T3R+v8WS3ZICFJuVbzCR90LE10P4qTSSajMMHmW0syGsT7CO?= =?iso-8859-1?q?IeJ2aaRS2ereRLkAQHqAo8xzbmBUuUbMFrjqV8HPLxZfXIv6Ex0EOeXhYKJ9?= =?iso-8859-1?q?CxMf34oS2aA38uY0wfhP1sWUeLqdqlTYwGQ/wxP+2nGoUAx+iq9ysQ6TIZlf?= =?iso-8859-1?q?w9DFFf15C+bfV14cn9c5v/tSqU1d5NepYHpxX6zI+SlH31QibaMvKUx+MpX0?= =?iso-8859-1?q?xllo1vDh4MF50SNWK5BLZh8Y4wCWTFGn3kdejSUNhfM+oxKnPCG5mss2NRDN?= =?iso-8859-1?q?BTipBL4vI0ifsKBU8LEGSnsjZN4MamC4X5RRfGPgltum8t0SqW6AXGYNtaY/?= =?iso-8859-1?q?3OnBJpdy53/1rXy4ZiBp4N/AZgzAF5rF+kTMqWOAFdGY56hG1NLwTbgoyork?= =?iso-8859-1?q?muyjsosrX2lYKsZ5OBbLw76f5S7r6AsWZhcpdwyAjZMTvmzRL/f8ei2wdLrf?= =?iso-8859-1?q?F1tvyQKJvrHQawL28c/MMbsDFGakTisSjWxnLw3Gj620jO0LoaKiQ+0RF1Hg?= =?iso-8859-1?q?6Ht0xQC0DyJ20VsWWEm7XUMDOj8vVhGPCYqnukt2sUecJ6ka3v45kqt8pyAT?= =?iso-8859-1?q?v7lo1aRm4EmcxMLmD6oXaIndkbE+Odimpxbk9unY4sJxVLGmmYHRex82LQ5d?= =?iso-8859-1?q?m85cusk8yNnINOSn03Awnnn4YVHqyZunjL6P/pKQ1KRa/Ab279c+95qZCE7G?= =?iso-8859-1?q?mknrNY9xsq77phgKtfM0gf6Tbj6gmBQq5JSARTr+WK6haFuF5Q5PbGFMcaxp?= =?iso-8859-1?q?BTAEdQysrX/oDnbBpXtKhLJTLxAs83dNDrJ/iFeTndQ2PdFrvDDh+g91i4kU?= =?iso-8859-1?q?RMLkEpvsFXslXjVBbEO2cIlr5CBw1/RKIKXKfgWYrS/kl7OPa0Xk5KJG6RR4?= =?iso-8859-1?q?nVCTJlFmyzh9ol0NAxwbRiSIhndreIe7WilSyQC4NRT5cYBwzByknOasUwsP?= =?iso-8859-1?q?xe4f+Xhx3pQQvkWCth8HyC3jU+otLKyt8u42RKlxFAlWss0w61mPztzI1Ig7?= =?iso-8859-1?q?iZyyCFAc3nKVIQwoiOp2uvWUvQawV0cS5LMJ5IaETa2bTj8mf3t0I1wNmw9E?= =?iso-8859-1?q?nL33R+cRTzXgXre5Z5BGEjXw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR14MB5713.namprd14.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(38070700018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?mxYf5l9kl/Q8oXFGYAeltN/?= =?iso-8859-1?q?0XsJx0KN9lSHzn5E7fb6F198+x6yKcc4mu292VPNspkFTqWW4fOjKg0ntJg+?= =?iso-8859-1?q?ybfjr5/WhjxFKEacly5mRj6CFE7jl8TwEbf0lMiuInqWrQ9wayyEwuhKeZh8?= =?iso-8859-1?q?fK62kA5C+qHmYBb3EuAVSFTOSQFN1fdAogxH/tVFxkc/fS2Mw2sCtXgRPLpT?= =?iso-8859-1?q?Z9uPAy4xT9FLidQ4lIvCwQv+/X1YYVtVNYNjDP5I01vZunINPslMEvJWD5cP?= =?iso-8859-1?q?Etc7Rt6W7ovEBj8X2RvZSqyiPMDPS8Lun7XltergsTdRhcrcA5cxvX5hHszu?= =?iso-8859-1?q?ytzRUu2/Fut9i7X0AEXHMNHg8hjRqhx5RxnEo2mt7V21CkzKJYrrY9WyXAh/?= =?iso-8859-1?q?2vwaE47Hf2g4C2U36VJJ3AU34cD6DjkjylYdlRVJ7V8ama6RmxBaKJhtKEj4?= =?iso-8859-1?q?I9SAig0PTnlduHAGgnj0HZPVaPDNjQBtCSZpFiPU4rv5vG9A/kTW4/jP1WKv?= =?iso-8859-1?q?NJvtXupo8YkjbXHH6zN+jhTt0iR3QaKmkjMkHQ1shzkeGlrcFgNQ9Ad/ytk1?= =?iso-8859-1?q?6FDjInP4VkAqnlzq2y4mv6HkMeAAJEYMF0ZM5ye6O+AjYjrinoxB2K1aGK6o?= =?iso-8859-1?q?44VD5ZvZlQ6MAffa2MEGh+38hMpYnlzhR/lF67zWiNs2KG8sUrRaG8ao0R0X?= =?iso-8859-1?q?koF2ktmNweX/8bAOlt6tos5tgfJbZHeOHaA/JcdN42WqyDrWiHo6UYEqGO4E?= =?iso-8859-1?q?cFkMR1A9W5hTfZCkHM/IwMt1F4IsD0JIDgTJ5oL+py1HOav79bSMIwEYw+RY?= =?iso-8859-1?q?aMJNaCT1d3IfP9tT8mCwHhlRLxfCFivJKMR37OFcwa49cGYFAe2VMNYtQ/je?= =?iso-8859-1?q?peiSbTBk7KrLk9hfA/pYHgxlCeRmpHXMxpHAL0ptNWSwnuKh6i+pAtibk9HD?= =?iso-8859-1?q?xta0hjgwuc/A8lm29dHhetkU8uurLkKbh8enQ7R7QUxd/fnDWRzO9+XW+QGg?= =?iso-8859-1?q?nHnV1V/kdo0clvnsqoo8YTzpO4iW7sg57T+JvpJ9Siyb7hV8XjtDGy4LCv+G?= =?iso-8859-1?q?s1W1D8sfzq7KJ81oG6J6oypqaKdXV2m7pBdLS27infR8vhgujONnArjpMsPE?= =?iso-8859-1?q?Yo5QXHHFGC8LLQAbvxVd2gpM+USvvc/MSTbJHD/4J+70LB2W9wKpZoHWaHr9?= =?iso-8859-1?q?JTCst0fbLrE9Y3zeNh07gJycw107V194ltls7X0ae6z2sYkRbtLlr4rw8WGS?= =?iso-8859-1?q?LJE4f/NVGFtEaF2dyltUoExNbVS2AbxnfgIB/Y6jn5Aj0Z9/3tclxoad7BRG?= =?iso-8859-1?q?M7PfbP5XdQL4IDPQPdLAwAUQXdgNq518v/O79IblDGKGd3CcZKBkIKxydMik?= =?iso-8859-1?q?pkW3gThtbqHtRrdPgABh+aBUNsr/RwefP++/hq1tTbaVUEiK5ff/lwx3pGBK?= =?iso-8859-1?q?Tp3SCvZ4o6ZYfBFQQbs2Y7RGfP3IQ2RR6hMm0B+ufqPBUKi47LuETszC3M7T?= =?iso-8859-1?q?cXpNBkMMBvlI3HKSJtifnUL4GTw1YZaABeEPu8Uq1Z0oMze87HS2DDv5w/FH?= =?iso-8859-1?q?0C6PvVGRws6ut9WpDV6kZ11Px3+dskfvy5Xs/mM9vuApMdFfrQVZIGqNINY0?= =?iso-8859-1?q?WvUHL70GX+eYPbFkewSxDDkk6VaMG0YNYrlaCa4GwBsxEFBh/rugwj2KZ/vH?= =?iso-8859-1?q?BLVCdCGkN8qkIPLYcD5zh?= MIME-Version: 1.0 X-OriginatorOrg: ezurio.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR14MB5713.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a505c72a-5af6-45c5-3566-08dcbd5b0b7b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2024 18:49:51.1576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a67ad7fe-2b14-4d12-b58f-bb509b58f338 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MB0FCnXycwNNaR0jjnoPup+aBUn3Q7B8rjgqqa3aNfkebZccCsb42YaRXTwL+AZl26x887B/URRPnLQVbW8Ufw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR14MB6634 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_115000_630666_5961713E X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: All, Apologies in advance if this has already been addressed. Found an issue using wpa_supplicant 2.11 (built with CONFIG_AP support) configured as an open AP. After a station connects to the AP, data packets are not passed -- pings fail. Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 ARC_VALID Message has a valid ARC signature -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 ARC_SIGNED Message has a ARC signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org All, Apologies in advance if this has already been addressed. Found an issue using wpa_supplicant 2.11 (built with CONFIG_AP support) configured as an open AP. After a station connects to the AP, data packets are not passed -- pings fail. The issue occurs with a thick-mac radio due to the WPA_STA_AUTHORIZED flag not being pushed. When the station connects, the AP handles the assoc event in wpa_supplicant_event_assoc():, and calls hostapd_notif_assoc():. hostapd_notif_assoc call hostapd_set_sta_flags() to push the flags -- unfortunately the AUTHORIZED flag hasn't been set yet. The AUTHORIZED flag isn't set until hostapd_new_assoc_sta() is called a few lines later. hostapd_new_assoc_sta(): calls ap_sta_set_authorized() for the open AP -- unfortunately the flag isn't pushed. One possible fix is to push the flag as follows: Regards, Doug THE INFORMATION CONTAINED IN THIS DOCUMENT IS OF A PROPRIETARY NATURE AND IS INTENDED TO BE KEPT CONFIDENTIAL BETWEEN THE SENDER AND THE INTENDED RECIPIENT. IT MAY NOT BE REPRODUCED OR USED WITHOUT EXPRESS WRITTEN PERMISSION OF EZURIO diff --git a/src/ap/hostapd.c b/src/ap/hostapd.c index c8ec1d624..d4a73510d 100644 --- a/src/ap/hostapd.c +++ b/src/ap/hostapd.c @@ -4042,6 +4042,8 @@ void hostapd_new_assoc_sta(struct hostapd_data *hapd, struct sta_info *sta, * been authorized. */ if (!hapd->conf->ieee802_1x && !hapd->conf->wpa && !hapd->conf->osen) { ap_sta_set_authorized(hapd, sta, 1); + // fix no ping -- push the authorized flag + hostapd_set_sta_flags(hapd, sta); os_get_reltime(&sta->connected_time); accounting_sta_start(hapd, sta); }