From patchwork Sat Sep 28 02:27:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ameer Antar X-Patchwork-Id: 1990456 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XFrqZ3gdHz1xtM for ; Sat, 28 Sep 2024 12:28:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:Message-ID:To:From :Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b2Ixcx1HjPqFTOCyoOxgEj1J+EI+ZoWrSGfhE+EjKsA=; b=UUoiz6W6VjIv3q tzuXdzULy3aP0TkXa+j/6TW77VyNi1zVX8IzBlAiQYf518u3NHJ8beq7h/NeI11Umx6dyM2fZ/ORw Np+KoBfi20wD/rJr6+BP7fnd3Ws5//YLF4FHTv3qRA+la5awKvW+ec/bb+76kUIOEglfttJ6xxOpy nggGcWWqcMVGmi98PTUdC8iGjq1JM6eHap1H0AO6x9Q3WEEczkzS5/GWQOVv7Iu7qYlgFUziUH4kr /0zUrsQAXZgZ9OtjEDnGiX9inGPUGMjsDx5e9T7ptokFsanZZVZwcZ9D78r0Ws8i75qHPFDtQuSq8 y3kciUiAptN/H/wiueEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1suNBT-0000000CU82-3TRC; Sat, 28 Sep 2024 02:27:47 +0000 Received: from resqmta-a2p-658480.sys.comcast.net ([2001:558:fd01:2bb4::7]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1suNBO-0000000CU7R-0mPE for hostap@lists.infradead.org; Sat, 28 Sep 2024 02:27:43 +0000 Received: from resomta-a2p-646771.sys.comcast.net ([96.103.145.239]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits) (Client did not present a certificate) by resqmta-a2p-658480.sys.comcast.net with ESMTPS id uMtXs8BcdmYyTuNBCscqRv; Sat, 28 Sep 2024 02:27:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1727490450; bh=HrMo+bTE9dTawAjZ+GrubX6M9q81SGfZUMmw99HbyWE=; h=Received:Received:Date:From:To:Message-ID:Subject:MIME-Version: Content-Type:Xfinity-Spam-Result; b=0atuHyWlJGBS2znWOAXLmWWpR+0l1bKssRFcwTImRZvw0pkmRO+NI1TkyyzK7vbts H8J0d6l2xnju60KXaGMH8QXzVfVOIhhaxKiOzX9IGaVNd5mvhl9gWIsc94Pr5ygfJV y2pM/KGyCwRnhmx6qFKwxsiyMC1gK/phoOZ7oAt6LolyELbh6+tbWIlBKfzf+JerAa MRt7xvvOVfN9M1AlieCjXMKNBWAkqs773f8aJNikdPgw1vjrxYwct7XfIiMiL85lXA IdMvYlQ44h7eK1dH9JOsSJ/LkTycl+P0mh6fc//dXgvf+pK7juNPEiVfbVCRcOj1Vt i+y0QYWmhJR6Q== Received: from boobie.home ([73.69.89.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-a2p-646771.sys.comcast.net with ESMTPSA id uNBAsEAXhx5isuNBAsvAQB; Sat, 28 Sep 2024 02:27:30 +0000 Date: Fri, 27 Sep 2024 22:27:28 -0400 (EDT) From: Ameer Antar To: hostap@lists.infradead.org Message-ID: <2096793269.2.1727490448894@boobie.home> Subject: Cannot compile sae_pk_gen without modifying Makefile MIME-Version: 1.0 X-CMAE-Envelope: MS4xfAiYGdwaLI28wjnG0Bs/wDM2Xj++CoXSQHSKlwUjOHRyGW3rPc0CmYNUUuYq8mZqU2ksdXx9cWnFYS8A12WVZoSJ6+dkSrwCFue6FJcxSlCkWr/uBJaU LJKkphoGFjSIk4vVR+TcYSPX/sAXnTa4GiNc0+SIzqrA7BEFQ4zctkpM+QQKLvN7DvzstqNzyF9LaA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_192742_321172_A26BE69C X-CRM114-Status: UNSURE ( 5.68 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Makefile is not properly setup to compile the sae_pk_gen target. Enabling CONFIG_SAE=y and CONFIG_SAE_PK=y in the configuration is not sufficient to compile. The linker complains about undefined r [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [ameerantar(at)comcast.net] X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The Makefile is not properly setup to compile the sae_pk_gen target. Enabling CONFIG_SAE=y and CONFIG_SAE_PK=y in the configuration is not sufficient to compile. The linker complains about undefined references. The following additions must be made to the Makefile to get it to compile, at least with gcc. Once this is done, 'make sae_pk_gen' can be run without issue. Signed-off-by: Ameer Antar --- -- diff --git a/hostapd/Makefile b/hostapd/Makefile index ca44392..afe3d5e 100644 --- a/hostapd/Makefile +++ b/hostapd/Makefile @@ -1372,6 +1372,11 @@ SOBJS += ../src/crypto/sha256-kdf.o SOBJS += ../src/crypto/sha384-kdf.o SOBJS += ../src/crypto/sha512-kdf.o +HOBJS += ../src/common/wpa_common.o +SOBJS += ../src/common/wpa_common.o +SOBJS += ../src/crypto/random.o +SOBJS += ../src/crypto/sha1-prf.o +SOBJS += ../src/utils/eloop.o _OBJS_VAR := NOBJS include ../src/objs.mk