From patchwork Thu Sep 5 05:55:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen Ye X-Patchwork-Id: 1981086 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MXE/GIDy; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=j2LAFf0l; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WzpXd07HGz1ygP for ; Thu, 5 Sep 2024 15:57:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FY6bOsjJWp2kMdqSwXYt2dLshT8iQpuQyOUdOIKhh60=; b=MXE/GIDyotzpe0 yzK8GfEidhyXj9BW6PZVSl+jt/VITJxQh8S7PABdUloCMTKHIiDbSFRFea89mrmqSh6t6yp5W28eF I1Jio1JAo04vQqf2dfa8770fZGI9lj4zcZY7iIOqlRhd1yEPfWERlqeFCx8IetYP3qC7qjp+VKD7M EcuqlB4ZFIABqw2TlaNqvqGzCCnDrgPPpoSXZvGN/gWc+xgqT+4irEu1RW6/VoLs8hOluHiXQKwC2 NkOfHpzdjOztozfTBoJQfD1vqOF18VLRTNHQb8o7TjZw6kaMyvy+os0zHhybLaRMjUC5E7f9Xg6bN XMkOHhD0E0FevEh6KxBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm5U4-000000076Pr-1Qw9; Thu, 05 Sep 2024 05:56:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm5U1-000000076Ow-2YFw for hostap@lists.infradead.org; Thu, 05 Sep 2024 05:56:43 +0000 X-UUID: 9d49d47e6b4b11efb3adad29d29602c1-20240904 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=oEJR+o/VbaxBgN/oXSoiSt9fA45PxqbaLUQtNVASwxA=; b=j2LAFf0ltNlvIUUrV5TwX/5Lq4ca196sQI8uKRAijLdsKa0AIcIEnIx499XGpuF2Ze6qo2NHlZZRM6z8GOoJfGgYHL/xS2Yj4KbZJ3UEDV0ZiJfCpy8nXBON6rndjhOB9DcT0KC6YokiK9vG+OuddWRVVuQdIGq188f0xOM/cYw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:32b615e8-7307-4b47-a184-e9936226bdd6,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6dc6a47,CLOUDID:2b5b3805-42cd-428b-a1e3-ab5b763cfa17,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_ULN,TF_CID_SPAM_SNR X-UUID: 9d49d47e6b4b11efb3adad29d29602c1-20240904 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1022753061; Wed, 04 Sep 2024 22:56:37 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 5 Sep 2024 13:56:04 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 5 Sep 2024 13:56:04 +0800 From: Allen Ye To: Jouni Malinen CC: , Felix Fietkau , Evelyn Tsai , "Money . Wang" , "Shayne Chen" , Allen Ye Subject: [PATCH] hostapd: Fix length of bandwidth indication subelement Date: Thu, 5 Sep 2024 13:55:28 +0800 Message-ID: <20240905055530.26519-1-allen.ye@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--5.224800-8.000000 X-TMASE-MatchedRID: dHqkmzbglWZDeuA2fujoFV4SsF49N47Ah+w9Wz/xXDpcU0dNErOD+vlY oV6p/cSxy5X05u8Zm4KAMuqetGVetiVvu9chHp+mavP8b9lJtWr6C0ePs7A07YFInLyeDAoZLSn Anmk9BMygmt3Mxcj0/xXFSpRFtZdbH0piLA5buKm6i2jyM7+h6w== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.224800-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: C7709C20E0449315C6090189F14B6BDD8E97BFCB909AF863A92EC1CBBFA5CED32000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_225641_695565_68F7A5E0 X-CRM114-Status: GOOD ( 10.89 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Shayne Chen The default length of the bandwidth indication subelement should be equal to the minimum size of ieee80211_bw_ind_element structure. Signed-off-by: Shayne Chen Signed-off-by: Allen Ye --- src/ap/ieee802_11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in sa-accredit.habeas.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in bl.score.senderscore.com] X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Shayne Chen The default length of the bandwidth indication subelement should be equal to the minimum size of ieee80211_bw_ind_element structure. Signed-off-by: Shayne Chen Signed-off-by: Allen Ye --- src/ap/ieee802_11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index 230fdb7b2..aeac546ff 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -7306,7 +7306,7 @@ static u8 * hostapd_eid_bw_indication(struct hostapd_data *hapd, u8 *eid, { u16 punct_bitmap = hostapd_get_punct_bitmap(hapd); struct ieee80211_bw_ind_element *bw_ind_elem; - size_t elen = 3; + size_t elen = 4; if (hapd->cs_freq_params.bandwidth <= 160 && !punct_bitmap) return eid;