diff mbox series

hostapd: fix BSS parameters change count on link removal

Message ID 20240724193706.1ee90d20aeed.Ie6d04c0a58c6fc17d44706c18e3b16dd27ab631b@changeid
State Accepted
Headers show
Series hostapd: fix BSS parameters change count on link removal | expand

Commit Message

Johannes Berg July 24, 2024, 5:37 p.m. UTC 
From: Johannes Berg <johannes.berg@intel.com>

The value currently is simply incremented, but it must not
reach 255 and rather wrap around from 254 to 0, since in
the Reduced Neighbor Report 255 means unknown. Fix that.

Fixes: d95838b7932b ("AP: Add support for testing ML link removal")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 src/ap/hostapd.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jouni Malinen Aug. 1, 2024, 3:36 p.m. UTC | #1 
On Wed, Jul 24, 2024 at 07:37:07PM +0200, Johannes Berg wrote:
> The value currently is simply incremented, but it must not
> reach 255 and rather wrap around from 254 to 0, since in
> the Reduced Neighbor Report 255 means unknown. Fix that.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/ap/hostapd.c b/src/ap/hostapd.c
index a05de030d91f..a0ac3a857823 100644
--- a/src/ap/hostapd.c
+++ b/src/ap/hostapd.c
@@ -440,6 +440,8 @@  int hostapd_link_remove(struct hostapd_data *hapd, u32 count)
 
 	hapd->eht_mld_link_removal_count = count;
 	hapd->eht_mld_bss_param_change++;
+	if (hapd->eht_mld_bss_param_change == 255)
+		hapd->eht_mld_bss_param_change = 0;
 
 	eloop_register_timeout(0, TU_TO_USEC(hapd->iconf->beacon_int),
 			       hostapd_link_remove_timeout_handler,