diff mbox series

Fix SignalChange property.

Message ID 20240716195304.339492-1-druth@chromium.org
State Accepted
Headers show
Series Fix SignalChange property. | expand

Commit Message

David Ruth July 16, 2024, 7:53 p.m. UTC 
SignalChange should be defined as a property of an interface.
Previously, it was incorrectly defined as a property of p2p peers.

Signed-off-by: David Ruth <druth@chromium.org>
---

 doc/dbus.doxygen               |  6 ++++++
 wpa_supplicant/dbus/dbus_new.c | 10 +++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

Comments

Jouni Malinen July 20, 2024, 5:36 p.m. UTC | #1 
On Tue, Jul 16, 2024 at 07:53:00PM +0000, David Ruth wrote:
> SignalChange should be defined as a property of an interface.
> Previously, it was incorrectly defined as a property of p2p peers.

Thanks, applied.
diff mbox series

Patch

diff --git a/doc/dbus.doxygen b/doc/dbus.doxygen
index 9f72614d4..070210945 100644
--- a/doc/dbus.doxygen
+++ b/doc/dbus.doxygen
@@ -1147,6 +1147,12 @@  fi.w1.wpa_supplicant1.CreateInterface.
       <li>
 	<h3>MACAddress - ay - (read)</h3>
 	<p>MAC address of the interface</p>
+      </li>
+
+      <li>
+	<h3>SignalChange - "a{sv}" - (read)</h3>
+	<p>Signal and quality properties of the interface</p>
+      </li>
     </ul>
 
 \subsection dbus_interface_signals Signals
diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
index ef7076934..76e42ffbc 100644
--- a/wpa_supplicant/dbus/dbus_new.c
+++ b/wpa_supplicant/dbus/dbus_new.c
@@ -4023,6 +4023,11 @@  static const struct wpa_dbus_property_desc wpas_dbus_interface_properties[] = {
 	  NULL,
 	  NULL,
 	},
+	{ "SignalChange", WPAS_DBUS_NEW_IFACE_INTERFACE, "a{sv}",
+	  wpas_dbus_getter_signal_change,
+	  NULL,
+	  NULL
+	},
 	{ NULL, NULL, NULL, NULL, NULL, NULL }
 };
 
@@ -4620,11 +4625,6 @@  static const struct wpa_dbus_property_desc wpas_dbus_p2p_peer_properties[] = {
 	  NULL,
 	  NULL
 	},
-	{ "SignalChange", WPAS_DBUS_NEW_IFACE_INTERFACE, "a{sv}",
-	  wpas_dbus_getter_signal_change,
-	  NULL,
-	  NULL
-	},
 	{ NULL, NULL, NULL, NULL, NULL, NULL }
 };