Message ID | 20240614081351.2088185-2-benjamin@sipsolutions.net |
---|---|
State | Accepted |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=11vaVrRs; dkim=temperror header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=tb3oE3aI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W0sXQ6g7Bz23v2 for <incoming@patchwork.ozlabs.org>; Fri, 14 Jun 2024 18:15:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FWS2EtvCrT3vtFdGI28/99V/SwJBpDnUmj/znqo3sMY=; b=11vaVrRsDvkXD3 gxhmMHPmR2vJypieFFidtgBhUSnyJVOCh9ms7wRWo+/W4Tw/4Q/4GPFtfir746TxqNI25hAluz8SC KnmhW6l3fDjrlxj44s1er56SMhzWXSys2CbcfB7nI2vf8Ow209V+EYhZoxBzsFI2h/J84ItLnPuGB DUa4uDY4IWtQQsn4DdvYaxfgqvXPlaxAvnlgSeM49iS0iXujVof6zcxTrIhaNvWcY3Q1tV4cGbFVl g21WPRUsvXuO2KXuB0VnzczOZLtFNYxSAEWnXFcN6rqW9ryQn1hcKNkTgSm4xZpYZks6SX+lN4C/a zX8OvBzecbAh2LxuJ8Aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI258-00000001wGE-1tRt; Fri, 14 Jun 2024 08:14:46 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI254-00000001wCy-0CGQ for hostap@lists.infradead.org; Fri, 14 Jun 2024 08:14:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=Cn3L8JDvYTQ8Qsdh2ICauP+4HSIJoWEuo//oR/myrs0=; t=1718352880; x=1719562480; b=tb3oE3aIlsPxfiVVe1LAiGk6BGRDdiUglqEmt9es+BVHZKx UOBkMBBqJ5tWFDMNzLHL68mQLzjpafou3yCUL1p34TcRhsLWl01rM/VrpDk03WoEuRNU19PWQERIh 7NRJGBSWvxNR5bIOcxqhzH8mnkG+yYWfXXkXifmvRpdG1jip9QuX3Xo90NKH/OQRsYaIhZNMzXL6R IzUQ/EpL4TsbhDXhq34gNKdNkxVFPoaWnpctCQRbIORfFAsPXMF/EIZ4JobPX2jKvh+vO6Pg2U6Rs ycd3/jn60IiBNxcd4hWGkIzPCOHCbNiV49knSRxgNFE/MX1VusyZFPDSzMx5HqRg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from <benjamin@sipsolutions.net>) id 1sI24z-0000000DZLi-2mdv; Fri, 14 Jun 2024 10:14:39 +0200 From: benjamin@sipsolutions.net To: hostap@lists.infradead.org Cc: Benjamin Berg <benjamin.berg@intel.com> Subject: [PATCH 01/10] MLD: Ensure link BSSIDs remain on stack for ignore Date: Fri, 14 Jun 2024 10:13:42 +0200 Message-ID: <20240614081351.2088185-2-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240614081351.2088185-1-benjamin@sipsolutions.net> References: <20240614081351.2088185-1-benjamin@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_011442_112880_59DAAC58 X-CRM114-Status: GOOD ( 10.81 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Benjamin Berg <benjamin.berg@intel.com> When ignoring a link BSSID the multi-link information was parsed out into a struct ml_sta_link_info on the stack. However, this stack variable went out of scope before it was used by passing the link_ [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Some ASAN/UBSAN related fixes
|
expand
|
diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c index 447fc8fd80..656bab5c44 100644 --- a/wpa_supplicant/events.c +++ b/wpa_supplicant/events.c @@ -5619,6 +5619,7 @@ static void wpas_event_assoc_reject(struct wpa_supplicant *wpa_s, { const u8 *bssid = data->assoc_reject.bssid; struct ieee802_11_elems elems; + struct ml_sta_link_info ml_info[MAX_NUM_MLD_LINKS]; const u8 *link_bssids[MAX_NUM_MLD_LINKS]; #ifdef CONFIG_MBO struct wpa_bss *reject_bss; @@ -5751,7 +5752,6 @@ static void wpas_event_assoc_reject(struct wpa_supplicant *wpa_s, if (ieee802_11_parse_elems(data->assoc_reject.resp_ies, data->assoc_reject.resp_ies_len, &elems, 1) != ParseFailed) { - struct ml_sta_link_info ml_info[MAX_NUM_MLD_LINKS]; unsigned int n_links, i, idx; idx = 0;