diff mbox series

[2/4] NAN: Reject undefined publish type

Message ID 20240427081946.147826-2-m@xv97.com
State Accepted
Headers show
Series [1/4] NAN: Fix a typo in USD doc | expand

Commit Message

Chien Wong April 27, 2024, 8:19 a.m. UTC 
The Wi-Fi Aware Specification v4.0 only defines unsolicited
transmissions only, solicited transmissions only and both unsolicited
and solicited transmissions publish. The other possibility is
undefined so we should reject it.

Signed-off-by: Chien Wong <m@xv97.com>
---
 src/common/nan_de.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/src/common/nan_de.c b/src/common/nan_de.c
index e1999a06b..7d8a952df 100644
--- a/src/common/nan_de.c
+++ b/src/common/nan_de.c
@@ -1209,6 +1209,11 @@  int nan_de_publish(struct nan_de *de, const char *service_name,
 		return -1;
 	}
 
+	if (!params->unsolicited && !params->solicited) {
+		wpa_printf(MSG_INFO, "NAN: Publish() - both unsolicited and solicited disabled is invalid");
+		return -1;
+	}
+
 	publish_id = nan_de_get_handle(de);
 	if (publish_id < 1)
 		return -1;