diff mbox series

[6/6] tests: MLO: add color change test

Message ID 20240422124005.3075001-7-quic_adisi@quicinc.com
State Accepted
Headers show
Series Add HE BSS color change support via cli | expand

Commit Message

Aditya Kumar Singh April 22, 2024, 12:40 p.m. UTC
Add eht_mlo_color_change test case to perform color change on first link
of a AP MLD. Performing on non-first link will be done later.

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
---
 tests/hwsim/test_eht.py | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

Comments

Jouni Malinen June 12, 2024, 9:45 a.m. UTC | #1
On Mon, Apr 22, 2024 at 06:10:05PM +0530, Aditya Kumar Singh wrote:
> Add eht_mlo_color_change test case to perform color change on first link
> of a AP MLD. Performing on non-first link will be done later.

> diff --git a/tests/hwsim/test_eht.py b/tests/hwsim/test_eht.py
> +def test_eht_mlo_color_change(dev, apdev):

> +        params = eht_mld_ap_wpa2_params(ssid, passphrase,
> +                                        key_mgmt="SAE", mfp="2", pwe='1')
> +        params['link_id'] = '0'
> +        params['he_bss_color'] = '42'

What's that link_id=0 parameter supposed to do? It does not exist in
hostapd and that forces this test case to be skipped.. I removed that
parameter and the test case passed.
Aditya Kumar Singh June 12, 2024, 10:34 a.m. UTC | #2
On 6/12/24 15:15, Jouni Malinen wrote:
> On Mon, Apr 22, 2024 at 06:10:05PM +0530, Aditya Kumar Singh wrote:
>> Add eht_mlo_color_change test case to perform color change on first link
>> of a AP MLD. Performing on non-first link will be done later.
> 
>> diff --git a/tests/hwsim/test_eht.py b/tests/hwsim/test_eht.py
>> +def test_eht_mlo_color_change(dev, apdev):
> 
>> +        params = eht_mld_ap_wpa2_params(ssid, passphrase,
>> +                                        key_mgmt="SAE", mfp="2", pwe='1')
>> +        params['link_id'] = '0'
>> +        params['he_bss_color'] = '42'
> 
> What's that link_id=0 parameter supposed to do? It does not exist in
> hostapd and that forces this test case to be skipped.. I removed that
> parameter and the test case passed.
>   

Oops! That came with MLO control socket changes. Fine to remove it for now.
diff mbox series

Patch

diff --git a/tests/hwsim/test_eht.py b/tests/hwsim/test_eht.py
index a012fe4e799d..30ce7a3dc45b 100644
--- a/tests/hwsim/test_eht.py
+++ b/tests/hwsim/test_eht.py
@@ -1823,3 +1823,42 @@  def test_eht_mlo_csa(dev, apdev):
             traffic_test(wpas, hapd0)
 
             #TODO: CSA on non-first link
+
+def test_eht_mlo_color_change(dev, apdev):
+    """EHT MLD AP. Color Change Announcement"""
+    with HWSimRadio(use_mlo=True) as (hapd_radio, hapd_iface), \
+        HWSimRadio(use_mlo=True) as (wpas_radio, wpas_iface):
+
+        ssid = "mld_ap"
+        passphrase = 'qwertyuiop'
+
+        params = eht_mld_ap_wpa2_params(ssid, passphrase,
+                                        key_mgmt="SAE", mfp="2", pwe='1')
+        params['link_id'] = '0'
+        params['he_bss_color'] = '42'
+
+        hapd0 = eht_mld_enable_ap(hapd_iface, params)
+
+        params['channel'] = '6'
+        params['link_id'] = '1'
+        params['he_bss_color'] = '24'
+
+        hapd1 = eht_mld_enable_ap(hapd_iface, params)
+
+        logger.info("Perform CCA on 1st link")
+        hapd0.request("COLOR_CHANGE 10")
+        time.sleep(1.5)
+
+        color = hapd0.get_status_field("he_bss_color")
+        if color != "10":
+            raise Exception("Expected current he_bss_color to be 10")
+
+        logger.info("Perform CCA on 1st link again")
+        hapd0.request("COLOR_CHANGE 60")
+        time.sleep(1.5)
+
+        color = hapd0.get_status_field("he_bss_color")
+        if color != "60":
+            raise Exception("Expected current he_bss_color to be 60")
+
+        #TODO: CCA on non-first link