From patchwork Mon Apr 8 13:06:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1920839 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=t2+8AcOt; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=W6uAoye6; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VCqD12Zmlz1yZW for ; Mon, 8 Apr 2024 23:08:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ksCM+MTiH9wZkywtxMroSfsI4qinA3FKjvnkdplE0GE=; b=t2+8AcOtbcgBzk tnAwSMpbide1s7dumWYSFjnOv/2aTwZu5hu6U59pWFEnE43rStSo1Jm5vkCKv8WPdnGggOsFyt5cS zkXCq04frZmwGmEw4+BpxMahUhus+aF6mc0Me9TSKqNe9n/Iu/nXmxBVUW6hYcWlxrB4mI21ZWSgZ Fc4GSKOZ4UpDtpOtKP7Ow1ulqYvdo6akZTl4OQxHs22WPt32nSPvl1lJ3p+GKwEKCtgCQqDtERG1D InvSLcz/QvIzG1HVkEOyIgr/tF5jaq/jhWOL1ZumngI+aXEywlSVbQAM9+lptA89wxUg+IRUkVAqc Ub8lJXLQ7j61cB0HJXDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtojY-0000000Fdt6-1iDv; Mon, 08 Apr 2024 13:08:24 +0000 Received: from mgamail.intel.com ([198.175.65.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtojQ-0000000FdrO-0FiC for hostap@lists.infradead.org; Mon, 08 Apr 2024 13:08:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712581696; x=1744117696; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SskWJWb2Cil3DdmQy6SaJ82CfOWg4BXqvCfG8BYOhbA=; b=W6uAoye6zByMkFWu8OEO/4mKyvCh1ORZtDyAFEd7hBTAOyTf4d4KY/Po 99HErCMFiREJAxSUGeV1S/NZvLGebdPVCiyJnkYKORJtk3p6G+PtRAJOx 5vPHO/Tx50ObTkNRyTQbw0Ronde0yxZ1wZn4XWOibPDiAYD5jDSLyU7ex 1GYUyu3W7h9FXo3tMku4cH9EKoWh2BSutTWi5JLiQ8D8nXF/hNGJhjzaH /bDte2SCvmWE9zBFQkl9kO+YbU/kjH6hAi/KYIhnu4GL9e7DQmhizzpx7 D5LDTwwIUnQPsKFMS61d9WmwkinSNOHe1iRjTvgogbCC+gteFS8hr//fW g==; X-CSE-ConnectionGUID: 4ThrKSFdQn2HqRY4H6SURw== X-CSE-MsgGUID: +R89m9BrSiC+XP/1Eo+1ZQ== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11688851" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="11688851" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 06:08:12 -0700 X-CSE-ConnectionGUID: ANJbXJW7SAOBaRqwm1UyPA== X-CSE-MsgGUID: XEw3hi2/QMqtXlHCQx0XAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="50868748" Received: from unknown (HELO WEIS0042.iil.intel.com) ([10.12.217.211]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 06:08:11 -0700 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Ilan Peer Subject: [PATCH 1/7] tests: Wait after removing a BSS Date: Mon, 8 Apr 2024 16:06:55 +0300 Message-ID: <20240408130701.531194-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_060816_175660_7B202B32 X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.4 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Ilan Peer When a BSS is removed, the flow continues without actually waiting for the AP to be stopped. This is racy in flows that actually expect the AP to be stopped, e.g., test_ap_bss_add_remove(). Content analysis details: (-2.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [198.175.65.14 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -1.5 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Ilan Peer When a BSS is removed, the flow continues without actually waiting for the AP to be stopped. This is racy in flows that actually expect the AP to be stopped, e.g., test_ap_bss_add_remove(). Try to mitigate such cases by adding a short sleep after the AP is removed. Signed-off-by: Ilan Peer --- tests/hwsim/hostapd.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/hwsim/hostapd.py b/tests/hwsim/hostapd.py index 007812274b..ebb2e328af 100644 --- a/tests/hwsim/hostapd.py +++ b/tests/hwsim/hostapd.py @@ -766,6 +766,9 @@ def remove_bss(apdev, ifname=None): hapd_global = HostapdGlobal(apdev) hapd_global.remove(ifname) + # wait little to make sure the AP stops beaconing + time.sleep(0.1) + def terminate(apdev): try: hostname = apdev['hostname']