Message ID | 20240306173947.2611965-11-quic_adisi@quicinc.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ijnm5Jaj; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=nWW8nKqu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tqfqc4fNDz1yX4 for <incoming@patchwork.ozlabs.org>; Thu, 7 Mar 2024 04:41:16 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ue3n0rp5Dle/zwaHiA/556UbJTkOrbjOz+8KtrHrkcE=; b=Ijnm5JajecmA+n w6zeGuUp7UbQUsVRz0j3K9TpoglPV9nxSoYK656GXjh1kd8saJNaJ4kNLy1zWH+D2kjufbjGOqoON 0lsRCws6q7nEynAXTs2yozEkFsBxFc5aQjK2lzAbMcTrorrB/9JTV4J1/YczDbPoiBxaFokUpJPJ2 li50Vavk2hrYkYbW1EFpg1i08zpthITgXCR29UYwUn4cG1WQo1VPBynpkkMJuidGLLoXZDQFyitBT 7/5AiocbkFcitSQKzrngekZfzm14vqjYhq8zzGZC7/hed9dJLwT06T5T0n6BNpSfm0dpJ3KHY3ft2 WJ1jrZ1S5DAAc8E7tfTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhvG5-00000001DyT-2vOk; Wed, 06 Mar 2024 17:40:49 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhvFn-00000001Dla-2naN for hostap@lists.infradead.org; Wed, 06 Mar 2024 17:40:33 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 426F2TDg015524 for <hostap@lists.infradead.org>; Wed, 6 Mar 2024 17:40:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= qcppdkim1; bh=KJLfo1pXD3b34Nsjtqjic89MIeKOXo2Cj0kRb8qTc2U=; b=nW W8nKquIiYI9OE/QAdR/GNRCjbu2sQDFXYzgqAVeAl9avGgLMQLb/O/y1HSMpQylZ HrPNHaQfgVpZnOwFmomKW1lH8d6y0rmXMIH7E4v5WeDQWFV0NBWJlRAPn80joyNW aREDiTHWgSKjEs07IjQbOlG4y3gHcvJOo6XHPEfSvYgjQp5xCIkB+mDYLHhfJlWh WqKCuRVvJEDQK/sN05EDoZVqBTKgxZeLUJTfPIXd34l6FV9ThQyRCkxhtFfWyR3Y xsLpscUImf/s5cDwhdSZOaYDF2+8mZxHfvWH9rojiiD2BhShsSAOoLdTWHdilRIA MGNmaUPyW9Hh08jQq7iw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wpts7rent-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <hostap@lists.infradead.org>; Wed, 06 Mar 2024 17:40:31 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 426HeU9M021807 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <hostap@lists.infradead.org>; Wed, 6 Mar 2024 17:40:30 GMT Received: from cdcwlex322514-lin.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 6 Mar 2024 09:40:28 -0800 From: Aditya Kumar Singh <quic_adisi@quicinc.com> To: <hostap@lists.infradead.org> CC: Aditya Kumar Singh <quic_adisi@quicinc.com> Subject: [PATCH 10/16] hostpad: MLO: nl80211: remove links while removing the interface Date: Wed, 6 Mar 2024 23:09:41 +0530 Message-ID: <20240306173947.2611965-11-quic_adisi@quicinc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240306173947.2611965-1-quic_adisi@quicinc.com> References: <20240306173947.2611965-1-quic_adisi@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 6kyGRRPG4HkwcyTxpCBmsn4CFD2r6VhJ X-Proofpoint-GUID: 6kyGRRPG4HkwcyTxpCBmsn4CFD2r6VhJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-06_11,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403060143 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_094031_882170_369335CC X-CRM114-Status: GOOD ( 13.76 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Currently, when interface is removed, the links added are not removed. While removing the interface, kernel has removed the stale links but hostapd has not. This is wrong since hostapd should remove a [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
hostapd: scale up MLO flows
|
expand
|
diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 7fa8a155f74d..ef9a513b663b 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -8965,6 +8965,7 @@ static int wpa_driver_nl80211_if_remove(struct i802_bss *bss, tbss->next = bss->next; /* Unsubscribe management frames */ nl80211_teardown_ap(bss); + nl80211_remove_links(bss); nl80211_destroy_bss(bss); if (!bss->added_if) i802_set_iface_flags(bss, 0); @@ -8979,6 +8980,7 @@ static int wpa_driver_nl80211_if_remove(struct i802_bss *bss, } else { wpa_printf(MSG_DEBUG, "nl80211: First BSS - reassign context"); nl80211_teardown_ap(bss); + nl80211_remove_links(bss); if (!bss->added_if && !drv->first_bss->next) wpa_driver_nl80211_del_beacon_all(bss); nl80211_destroy_bss(bss);
Currently, when interface is removed, the links added are not removed. While removing the interface, kernel has removed the stale links but hostapd has not. This is wrong since hostapd should remove and do the clean ups properly while removing the interface. Hence add changes to remove links when interface is removed. Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com> --- src/drivers/driver_nl80211.c | 2 ++ 1 file changed, 2 insertions(+)