diff mbox series

[1/2] OpenSSL: Fix a memory leak on openssl_evp_pkey_ec_prime_len() error path

Message ID 20240305142041.542353-1-m@xv97.com
State Accepted
Headers show
Series [1/2] OpenSSL: Fix a memory leak on openssl_evp_pkey_ec_prime_len() error path | expand

Commit Message

Chien Wong March 5, 2024, 2:20 p.m. UTC 
Fixes: b700a56e1478 ("OpenSSL 3.0: Determine the prime length for an EC key group using EVP_PKEY!)
Signed-off-by: Chien Wong <m@xv97.com>
---
 src/crypto/crypto_openssl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jouni Malinen March 8, 2024, 8:59 a.m. UTC | #1 
Thanks, both patches applied.
diff mbox series

Patch

diff --git a/src/crypto/crypto_openssl.c b/src/crypto/crypto_openssl.c
index 427677d34..315c3feac 100644
--- a/src/crypto/crypto_openssl.c
+++ b/src/crypto/crypto_openssl.c
@@ -3932,9 +3932,10 @@  static int openssl_evp_pkey_ec_prime_len(struct crypto_ec_key *key)
 	group = EC_GROUP_new_by_curve_name(nid);
 	prime = BN_new();
 	if (!group || !prime)
-		return -1;
+		goto fail;
 	if (EC_GROUP_get_curve(group, prime, NULL, NULL, NULL) == 1)
 		prime_len = BN_num_bytes(prime);
+fail:
 	EC_GROUP_free(group);
 	BN_free(prime);
 	return prime_len;