[02/12] hwsim: explicitly set address to bind to

Message ID	20231225102109.2853783-3-andrei.otcheretianski@intel.com
State	Accepted
Headers	show Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com> To: hostap@lists.infradead.org Cc: Benjamin Berg <benjamin.berg@intel.com> Subject: [PATCH 02/12] hwsim: explicitly set address to bind to Date: Mon, 25 Dec 2023 12:20:59 +0200 Message-ID: <20231225102109.2853783-3-andrei.otcheretianski@intel.com> In-Reply-To: <20231225102109.2853783-1-andrei.otcheretianski@intel.com> References: <20231225102109.2853783-1-andrei.otcheretianski@intel.com> MIME-Version: 1.0 preview: From: Benjamin Berg <benjamin.berg@intel.com> pyrad internally uses socket.getaddrinfo. While it is documented that one can pass an empty string to bind to all interfaces. The underlying function expects None instead though, breaking the call. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.55.52.43 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 2.5 DATE_IN_FUTURE_12_24 Date: is 12 to 24 hours after Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Various hwsim fixes \| expand [00/12] Various hwsim fixes [01/12] hwsim: Strip trailing space from ip output [02/12] hwsim: explicitly set address to bind to [03/12] hwsim: write services needed for pyrad [04/12] hwsim: Use pgrep instead of ps [05/12] hwsim: Stop WPA AP at end of VHT 80 MHz (US) test [06/12] hwsim: Flag inside VM using an environment variable [07/12] Disable _FORTIFY_SOURCE when building with -O0 [08/12] build: Properly grab the libpcsclite cflags [09/12] tests: Optimize process memory reading using join [10/12] tests: ap_vht_40: wait a bit before connectivity check [11/12] tests: P2P: also wait in go_neg_pbc() [12/12] tests: run kmemleak between tests if available

Message ID

20231225102109.2853783-3-andrei.otcheretianski@intel.com

State

Accepted

Headers

From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
To: hostap@lists.infradead.org
Cc: Benjamin Berg <benjamin.berg@intel.com>
Subject: [PATCH 02/12] hwsim: explicitly set address to bind to
Date: Mon, 25 Dec 2023 12:20:59 +0200
Message-ID: <20231225102109.2853783-3-andrei.otcheretianski@intel.com>
In-Reply-To: <20231225102109.2853783-1-andrei.otcheretianski@intel.com>
References: <20231225102109.2853783-1-andrei.otcheretianski@intel.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Hostap" <hostap-bounces@lists.infradead.org>
Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Various hwsim fixes | expand

Commit Message

Andrei Otcheretianski Dec. 25, 2023, 10:20 a.m. UTC

From: Benjamin Berg <benjamin.berg@intel.com>

pyrad internally uses socket.getaddrinfo. While it is documented that
one can pass an empty string to bind to all interfaces. The underlying
function expects None instead though, breaking the call.

Either way, it does not hurt to set the bind address to 127.0.0.1
explicitly, so do so to avoid issues.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
---
 tests/hwsim/test_eap_proto.py | 2 +-
 tests/hwsim/test_radius.py    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/hwsim/test_eap_proto.py b/tests/hwsim/test_eap_proto.py
index a1270ac3c6..e125481717 100644
--- a/tests/hwsim/test_eap_proto.py
+++ b/tests/hwsim/test_eap_proto.py
@@ -160,7 +160,7 @@  def start_radius_server(eap_handler):
     srv.hosts["127.0.0.1"] = pyrad.server.RemoteHost("127.0.0.1",
                                                      b"radius",
                                                      "localhost")
-    srv.BindToAddress("")
+    srv.BindToAddress("127.0.0.1")
     t_stop = threading.Event()
     t = threading.Thread(target=run_pyrad_server, args=(srv, t_stop, eap_handler))
     t.start()
diff --git a/tests/hwsim/test_radius.py b/tests/hwsim/test_radius.py
index 5f1f4f175f..224bff177d 100644
--- a/tests/hwsim/test_radius.py
+++ b/tests/hwsim/test_radius.py
@@ -1132,7 +1132,7 @@  def test_radius_protocol(dev, apdev):
     srv.hosts["127.0.0.1"] = pyrad.server.RemoteHost("127.0.0.1",
                                                      b"radius",
                                                      "localhost")
-    srv.BindToAddress("")
+    srv.BindToAddress("127.0.0.1")
     t_events = {}
     t_events['stop'] = threading.Event()
     t_events['msg_auth'] = threading.Event()
@@ -1249,7 +1249,7 @@  def start_radius_psk_server(psk, invalid_code=False, acct_interim_interval=0,
     srv.hosts["127.0.0.1"] = pyrad.server.RemoteHost("127.0.0.1",
                                                      b"radius",
                                                      "localhost")
-    srv.BindToAddress("")
+    srv.BindToAddress("127.0.0.1")
     t_events = {}
     t_events['stop'] = threading.Event()
     t_events['psk'] = psk
@@ -1595,7 +1595,7 @@  def test_ap_vlan_wpa2_psk_radius_required(dev, apdev):
     srv.hosts["127.0.0.1"] = pyrad.server.RemoteHost("127.0.0.1",
                                                      b"radius",
                                                      "localhost")
-    srv.BindToAddress("")
+    srv.BindToAddress("127.0.0.1")
     t_events = {}
     t_events['stop'] = threading.Event()
     t_events['long'] = threading.Event()

[02/12] hwsim: explicitly set address to bind to

Commit Message

Patch