Message ID | 20231124143649.110325-1-juliusz@wolfssl.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fpS7JM8u; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wolfssl-com.20230601.gappssmtp.com header.i=@wolfssl-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=QBUMccIz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ScHdc3GSqz1ySk for <incoming@patchwork.ozlabs.org>; Sat, 25 Nov 2023 01:37:56 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qefn0unwtVx0xEWQX/7n7LMq6Fs0dQppsVoEi8Ljv/4=; b=fpS7JM8u5m5yPd WzY/xUSzEnB5F9k7Et2J/0NLmcZOM/vF+htRFZkasA7ktQE8BddHghxVYmPMu7dKNAUa993b1zKwx M5GBn/nW0ezl22NH+PxySEaBWsRKjRpfAfrsmzfSiYEKsaApndaUkeq2vK/xp0UCanxqRmrg26aI6 /5pgR3eCN/PvLb/TlJxrsiYLO/RfJ6oV9GScafG9qXhxMIfxkYqX3vWQVRGFUUVornKTOMEzwdW0w x4P00cvinUinr5f6yWdgCIXYFjXfaiYiOS5NeQo406QKVNtvh+0Vi6zFj0gbU0JWYGGu1zZzywIoX QxgJN7wNGVsCRo9aOaYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6XIk-007QHy-2t; Fri, 24 Nov 2023 14:37:02 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6XIi-007QGK-0Q for hostap@lists.infradead.org; Fri, 24 Nov 2023 14:37:01 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c875207626so24379281fa.1 for <hostap@lists.infradead.org>; Fri, 24 Nov 2023 06:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfssl-com.20230601.gappssmtp.com; s=20230601; t=1700836617; x=1701441417; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ADbQSz4+Xs5xzoZpEyvTkcZeKb3nmdxS5zgE1baF9fo=; b=QBUMccIziZaG/l5RO81kGoHxOfeh1VjbV5Kc282sZiF+u3l/prd6nG0WHMZag534VG z4+wZmB3EynAxTzTSp/roiBsa4lbYiaek2X+f9fuZ+Yc2DovNxUbBPDnwoSl5Rgb7OGV KH2F6MxW+NyGgschmDADfGIc1HUm9APWVsu1dri2WJBTlgb26hOHdEg7QVn0KTj+pTsZ 2sKbniESvpA3wIXY5k5F5MO2a0/+nDBwmPHZ6YIeFwE96UNyX5nZGoVhZbYGEsCZ/ny+ x4k8BduOJybWV6xbk87LoOS5hKGXCmznC6YqjuhMJKodfsoB65yk+jYZP5KhzhyxAEug 0Szg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700836617; x=1701441417; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ADbQSz4+Xs5xzoZpEyvTkcZeKb3nmdxS5zgE1baF9fo=; b=lUehSQwkInBHepdOyo2reRY53NrpRkTx4JC4PBzx6apgkJ6eK03xDTSCDAHW2MxTi0 8rzSVc4uyUZ0PYMfMsFwNCGsB7HahZSEGmZWyN6rrkqg118zhpIRltKwT11z8YC7OTnw w/hb9iNTCgiyN/6BdYKueDI3xLa6hkbYP0UbKe8IIWngyGfJJ0/OaOdbKfk9O33AuV7i kVXmxBwo5NHmLgLetOJFYHRqafKP7CW18sRYTf3GXQV9LJRz4gXWlANIHaAl43B8zfRT aSNKdMe34DlklD744oO4ynIUdVl3DPmhTLteaPZGPgbM+35v0UT1jbvNE5bQ3vKif8CV KK4g== X-Gm-Message-State: AOJu0YwbYSJB3HvCBcsJXjqfbh2SqEJHObPfRV1a8soBBsZ2x6j8Y7On O0SLkYs46cPD9OosW2XyyRYhXkKF/o2a5/EDEdtLZnd+ X-Google-Smtp-Source: AGHT+IFrr9ssoKx6BD8bvqK9ZW0g3RHNjPqYLrj/m1r8H8daD5OrqMfS3GKtm2B15b2ZaZx7iwtqkg== X-Received: by 2002:a2e:8747:0:b0:2c5:1eb6:bd18 with SMTP id q7-20020a2e8747000000b002c51eb6bd18mr2182410ljj.53.1700836616695; Fri, 24 Nov 2023 06:36:56 -0800 (PST) Received: from localhost.localdomain ([85.203.44.50]) by smtp.gmail.com with ESMTPSA id k15-20020a2ea28f000000b002c78228dea1sm488895lja.100.2023.11.24.06.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 06:36:56 -0800 (PST) From: Juliusz Sosinowicz <juliusz@wolfssl.com> To: hostap@lists.infradead.org Cc: Juliusz Sosinowicz <juliusz@wolfssl.com> Subject: [PATCH] sae: prime_len means length in bytes not bits Date: Fri, 24 Nov 2023 15:36:49 +0100 Message-Id: <20231124143649.110325-1-juliusz@wolfssl.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_063700_368423_9A07DCC7 X-CRM114-Status: GOOD ( 11.82 ) X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The prime_len variable is used as the length in bytes but it is set as the length in bits. This fixes the sae DH group tests with wolfSSL. Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com> --- src/common/sae.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:235 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
sae: prime_len means length in bytes not bits
|
expand
|
On Fri, Nov 24, 2023 at 03:36:49PM +0100, Juliusz Sosinowicz wrote:
> The prime_len variable is used as the length in bytes but it is set as the length in bits. This fixes the sae DH group tests with wolfSSL.
Thanks, applied.
diff --git a/src/common/sae.c b/src/common/sae.c index d4a196f153..f1c164e138 100644 --- a/src/common/sae.c +++ b/src/common/sae.c @@ -458,7 +458,7 @@ static int sae_derive_pwe_ffc(struct sae_data *sae, const u8 *addr1, * mask */ u8 mask; struct crypto_bignum *pwe; - size_t prime_len = sae->tmp->prime_len * 8; + size_t prime_len = sae->tmp->prime_len; u8 *pwe_buf; crypto_bignum_deinit(sae->tmp->pwe_ffc, 1);
The prime_len variable is used as the length in bytes but it is set as the length in bits. This fixes the sae DH group tests with wolfSSL. Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com> --- src/common/sae.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)