| Message ID | 20220112000022.1688136-1-arowa@google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] wpa_supplicant: src: Remove the word "whitelist" | expand |
Hi Sorry for the dumb question: Am I the only one who thinks Arowa is wasting his time trying to save the world by replacing well established expressions by some expressions he likes more? A car is a car and doesn't have to be called a "vehicel-with-four-or-more-wheels", c'mon.... Every kid knows what a white- and black-list is. Arowa, what about doing something really usefull? Regards, Chris On Tue, Jan 11, 2022 at 04:00:20PM -0800, Arowa Suliman wrote: > Replace the word "whitelist" with the inclusive word "allowlist" > > Signed-off-by: Arowa Suliman <arowa@chromium.org> > --- > src/common/qca-vendor.h | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/common/qca-vendor.h b/src/common/qca-vendor.h > index d9eab0212..6e2d51fac 100644 > --- a/src/common/qca-vendor.h > +++ b/src/common/qca-vendor.h > @@ -4863,14 +4863,14 @@ enum qca_vendor_attr_roam_control { > * ignored BSSIDs and accordingly clear the respective ones with the > * matching ID. > * > - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS: Unsigned > - * 32-bit value.Represents the number of whitelist SSIDs configured. > + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS: Unsigned > + * 32-bit value.Represents the number of allowlist SSIDs configured. > * > - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST: Nested attribute > - * to carry the list of Whitelist SSIDs. > + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_LIST: Nested attribute > + * to carry the list of Allowlist SSIDs. > * > - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID: SSID (binary attribute, > - * 0..32 octets). Represents the white list SSID. Whitelist SSIDs > + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID: SSID (binary attribute, > + * 0..32 octets). Represents the allow list SSID. Allowlist SSIDs > * represent the list of SSIDs to which the firmware/driver can consider > * to roam to. > * > @@ -4908,7 +4908,7 @@ enum qca_vendor_attr_roam_control { > * > * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_SET_LAZY_ROAM_ENABLE: Unsigned 32-bit > * value. 1-Enable, 0-Disable. Represents "Lazy" mode, where > - * firmware is hunting for a better BSSID or white listed SSID even though > + * firmware is hunting for a better BSSID or allow listed SSID even though > * the RSSI of the link is good. The parameters enabling the roaming are > * configured through the PARAM_A_BAND_XX attrbutes. > * > @@ -4950,7 +4950,7 @@ enum qca_wlan_vendor_attr_roaming_config_params { > QCA_WLAN_VENDOR_ATTR_ROAMING_SUBCMD = 1, > QCA_WLAN_VENDOR_ATTR_ROAMING_REQ_ID = 2, > > - /* Attributes for wifi_set_ssid_white_list */ > + /* Attributes for wifi_set_ssid_allow_list */ > QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS = 3, > QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST = 4, > QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID = 5, > @@ -4992,12 +4992,12 @@ enum qca_wlan_vendor_attr_roaming_config_params { > * enum qca_wlan_vendor_roaming_subcmd: Referred by > * QCA_WLAN_VENDOR_ATTR_ROAMING_SUBCMD. > * > - * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SSID_WHITE_LIST: Sub command to > - * configure the white list SSIDs. These are configured through > + * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SSID_ALLOW_LIST: Sub command to > + * configure the allow list SSIDs. These are configured through > * the following attributes. > - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS, > - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST, > - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID > + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS, > + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_LIST, > + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID > * > * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SET_GSCAN_ROAM_PARAMS: Sub command to > * configure the Roam params. These parameters are evaluated on the GScan > -- > 2.34.1.703.g22d0c6ccf7-goog > > > _______________________________________________ > Hostap mailing list > Hostap@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/hostap
On Wed, Jan 12, 2022 at 10:59:01PM +0100, Chris Osicki wrote: > Am I the only one who thinks Arowa is wasting his time trying to save the world by replacing well established > expressions by some expressions he likes more? I'd assume there are both people that are in favor and people that are against this type of changes. While I do not want to cause undue issues with renaming, especially for cases where the impact would be outside the hostap.git internal items, I do support many of the changes where the proposed new term/language is clear. This particular example of white/blacklisting is something that has already been renamed in cases that were fully internal to hostap.git and a temporary backwards compatibility alias was left for cases that had an impact to external users in configuration items. It seems reasonable to go through the main remaining item with such terminology, i.e., this qca-vendor.h file.
On Wed, Jan 12, 2022 at 2:13 PM Chris Osicki <hostapd@osk.ch> wrote: > > > Hi > > Sorry for the dumb question: > Am I the only one who thinks Arowa is wasting his time trying to save the world by replacing well established > expressions by some expressions he likes more? > A car is a car and doesn't have to be called a "vehicel-with-four-or-more-wheels", c'mon.... > Every kid knows what a white- and black-list is. Words such as whitelist, blacklist, master, and slave are clearly opressive to many people such as African Americans. I am just suggesting changes to these words, not simply forcing replacements that I like more. I think Jouni has been doing great work by only accepting changes where backward compatibility is maintained and meaning of terms is clear. > Arowa, what about doing something really usefull? I think removing oppressive language/terms in open source code is something very useful. Thanks, Arowa Suliman
On 12/01/2022 23.59, Chris Osicki wrote: > Hi > > Sorry for the dumb question: > Am I the only one who thinks Arowa is wasting his time trying to save the world by replacing well established > expressions by some expressions he likes more? No, you're obviously not the only one, but let's respect other people's right to waste their own time any way they want. As long as it doesn't waste anyone else's time (e.g. by introducing backward incompatible changes in public APIs), there's nothing to worry about, really. I suggest to take it easy. Cheers, =S.
diff --git a/src/common/qca-vendor.h b/src/common/qca-vendor.h index d9eab0212..6e2d51fac 100644 --- a/src/common/qca-vendor.h +++ b/src/common/qca-vendor.h @@ -4863,14 +4863,14 @@ enum qca_vendor_attr_roam_control { * ignored BSSIDs and accordingly clear the respective ones with the * matching ID. * - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS: Unsigned - * 32-bit value.Represents the number of whitelist SSIDs configured. + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS: Unsigned + * 32-bit value.Represents the number of allowlist SSIDs configured. * - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST: Nested attribute - * to carry the list of Whitelist SSIDs. + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_LIST: Nested attribute + * to carry the list of Allowlist SSIDs. * - * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID: SSID (binary attribute, - * 0..32 octets). Represents the white list SSID. Whitelist SSIDs + * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID: SSID (binary attribute, + * 0..32 octets). Represents the allow list SSID. Allowlist SSIDs * represent the list of SSIDs to which the firmware/driver can consider * to roam to. * @@ -4908,7 +4908,7 @@ enum qca_vendor_attr_roam_control { * * @QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_SET_LAZY_ROAM_ENABLE: Unsigned 32-bit * value. 1-Enable, 0-Disable. Represents "Lazy" mode, where - * firmware is hunting for a better BSSID or white listed SSID even though + * firmware is hunting for a better BSSID or allow listed SSID even though * the RSSI of the link is good. The parameters enabling the roaming are * configured through the PARAM_A_BAND_XX attrbutes. * @@ -4950,7 +4950,7 @@ enum qca_wlan_vendor_attr_roaming_config_params { QCA_WLAN_VENDOR_ATTR_ROAMING_SUBCMD = 1, QCA_WLAN_VENDOR_ATTR_ROAMING_REQ_ID = 2, - /* Attributes for wifi_set_ssid_white_list */ + /* Attributes for wifi_set_ssid_allow_list */ QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS = 3, QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST = 4, QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID = 5, @@ -4992,12 +4992,12 @@ enum qca_wlan_vendor_attr_roaming_config_params { * enum qca_wlan_vendor_roaming_subcmd: Referred by * QCA_WLAN_VENDOR_ATTR_ROAMING_SUBCMD. * - * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SSID_WHITE_LIST: Sub command to - * configure the white list SSIDs. These are configured through + * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SSID_ALLOW_LIST: Sub command to + * configure the allow list SSIDs. These are configured through * the following attributes. - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS, - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_LIST, - * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS, + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_LIST, + * QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID * * @QCA_WLAN_VENDOR_ROAMING_SUBCMD_SET_GSCAN_ROAM_PARAMS: Sub command to * configure the Roam params. These parameters are evaluated on the GScan
Replace the word "whitelist" with the inclusive word "allowlist" Signed-off-by: Arowa Suliman <arowa@chromium.org> --- src/common/qca-vendor.h | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)