| Message ID | 20210919062432.431077-7-arowa@google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Replace oppressive terms with inclusive terms | expand |
On Sat, Sep 18, 2021 at 11:24:31PM -0700, Arowa Suliman wrote: > Replaced the word Native with more inclusive words such as built-in. While I'm not necessarily against some of these changes, I'm not convinced there is strong need to replace terms like "native interface" and I don't really like to make such changes just to get rid of the word "native" if the new version is inaccurate or more difficult to understand. > diff --git a/doc/code_structure.doxygen b/doc/code_structure.doxygen > @@ -62,7 +62,7 @@ with with hostapd. The following C files are currently used: > \ref l2_packet.h, \ref l2_packet_linux.c, and \ref l2_packet_pcap.c > - Layer 2 (link) access wrapper (includes native Linux implementation > + Layer 2 (link) access wrapper (includes Linux packet socket > and wrappers for libdnet/libpcap). A new l2_packet implementation This feels fine since it is a more specific reference to what this is talking about. > diff --git a/doc/driver_wrapper.doxygen b/doc/driver_wrapper.doxygen > @@ -27,10 +27,10 @@ documented in \ref driver.h. In addition, a pointer to the 'struct > When porting to other operating systems, the driver wrapper should be > -modified to use the native interface of the target OS. It is possible > -that some extra requirements for the interface between the driver > -wrapper and generic wpa_supplicant code are discovered during porting > -to a new operating system. These will be addressed on case by case > +modified to use the direct interface of the target OS (No extra adoption > +layer). It is possible that some extra requirements for the interface between > +the driver wrapper and generic wpa_supplicant code are discovered during > +porting to a new operating system. These will be addressed on case by case This looks more difficult to understand since "native interface" is the technical term used for referring to the interface provided by a component like the operating system. Trying to replace that with "direct interface" and a parenthetical to explain the uncommon term for that does not exactly improve readability here.. > diff --git a/doc/p2p.doxygen b/doc/p2p.doxygen > @@ -274,8 +274,8 @@ for removing the group interface for the failed group. > P2P protocol includes service discovery functionality that can be used > to discover which services are provided by the peers before forming a > group. This leverages the Generic Advertisement Service (GAS) protocol > -from IEEE 802.11u and P2P vendor-specific contents inside the Native > -GAS messages. > +from IEEE 802.11u and P2P vendor-specific contents inside the GAS > +messages. This is fine since I don't even remember where that previously used term came from. > diff --git a/doc/porting.doxygen b/doc/porting.doxygen > @@ -21,7 +21,8 @@ most targets. However, couple of additional functions that are common > on modern UNIX systems are used. Number of these are listed with > prototypes in \ref common.h (the \verbatim #ifdef CONFIG_ANSI_C_EXTRA \endverbatim > block). These functions may need to be implemented or at least defined > -as macros to native functions in the target OS or C library. > +as macros to direct functions in the target OS (No extra adoption layer) or C > +library. This is in the same category with "native interface". Use of an uncommon term that requires a parenthetical to explain what is meant here is not a good approach. > diff --git a/wpa_supplicant/ChangeLog b/wpa_supplicant/ChangeLog > @@ -1864,7 +1864,7 @@ ChangeLog for wpa_supplicant > * l2_packet_linux: use socket type SOCK_DGRAM instead of SOCK_RAW for > PF_PACKET in order to prepare for network devices that do not use > - Ethernet headers (e.g., network stack with native IEEE 802.11 frames) > + Ethernet headers (e.g., network stack that includes IEEE 802.11 headers) This feels a bit borderline regarding clarity due to the use of native 802.11 frames in multiple different interfaces and loss of that common term. Technically, it feels incorrect to say that a network stack includes a header. Maybe something like "networks stacks that include the IEEE 802.11 header in the frames" would be accurate.
diff --git a/doc/code_structure.doxygen b/doc/code_structure.doxygen index 3a3b21b72..927ea4e85 100644 --- a/doc/code_structure.doxygen +++ b/doc/code_structure.doxygen @@ -62,7 +62,7 @@ with with hostapd. The following C files are currently used: Definitions shared by multiple files \ref l2_packet.h, \ref l2_packet_linux.c, and \ref l2_packet_pcap.c - Layer 2 (link) access wrapper (includes native Linux implementation + Layer 2 (link) access wrapper (includes Linux packet socket and wrappers for libdnet/libpcap). A new l2_packet implementation may need to be added when porting to new operating systems that are not supported by libdnet/libpcap. Makefile can be used to select which diff --git a/doc/driver_wrapper.doxygen b/doc/driver_wrapper.doxygen index 66211b3ab..37e39de90 100644 --- a/doc/driver_wrapper.doxygen +++ b/doc/driver_wrapper.doxygen @@ -27,10 +27,10 @@ documented in \ref driver.h. In addition, a pointer to the 'struct \ref wpa_driver_ops' needs to be registered in \ref drivers.c file. When porting to other operating systems, the driver wrapper should be -modified to use the native interface of the target OS. It is possible -that some extra requirements for the interface between the driver -wrapper and generic wpa_supplicant code are discovered during porting -to a new operating system. These will be addressed on case by case +modified to use the direct interface of the target OS (No extra adoption +layer). It is possible that some extra requirements for the interface between +the driver wrapper and generic wpa_supplicant code are discovered during +porting to a new operating system. These will be addressed on case by case basis by modifying the interface and updating the other driver wrappers for this. The goal is to avoid changing this interface without very good reasons in order to limit the number of changes diff --git a/doc/p2p.doxygen b/doc/p2p.doxygen index d4d86e3ed..6ab6e9e05 100644 --- a/doc/p2p.doxygen +++ b/doc/p2p.doxygen @@ -274,8 +274,8 @@ for removing the group interface for the failed group. P2P protocol includes service discovery functionality that can be used to discover which services are provided by the peers before forming a group. This leverages the Generic Advertisement Service (GAS) protocol -from IEEE 802.11u and P2P vendor-specific contents inside the Native -GAS messages. +from IEEE 802.11u and P2P vendor-specific contents inside the GAS +messages. The P2P module takes care of GAS encapsulation, fragmentation, and actual transmission and reception of the Action frames needed for diff --git a/doc/porting.doxygen b/doc/porting.doxygen index b4b78ef05..a302dbf1a 100644 --- a/doc/porting.doxygen +++ b/doc/porting.doxygen @@ -21,7 +21,8 @@ most targets. However, couple of additional functions that are common on modern UNIX systems are used. Number of these are listed with prototypes in \ref common.h (the \verbatim #ifdef CONFIG_ANSI_C_EXTRA \endverbatim block). These functions may need to be implemented or at least defined -as macros to native functions in the target OS or C library. +as macros to direct functions in the target OS (No extra adoption layer) or C +library. Many of the common ANSI C functions are used through a wrapper definitions in \ref os.h to allow these to be replaced easily with a diff --git a/wpa_supplicant/ChangeLog b/wpa_supplicant/ChangeLog index a06a93b22..39f3a7478 100644 --- a/wpa_supplicant/ChangeLog +++ b/wpa_supplicant/ChangeLog @@ -1864,7 +1864,7 @@ ChangeLog for wpa_supplicant generate, e.g., man pages * l2_packet_linux: use socket type SOCK_DGRAM instead of SOCK_RAW for PF_PACKET in order to prepare for network devices that do not use - Ethernet headers (e.g., network stack with native IEEE 802.11 frames) + Ethernet headers (e.g., network stack that includes IEEE 802.11 headers) * use receipt of EAPOL-Key frame as a lower layer success indication for EAP state machine to allow recovery from dropped EAP-Success frame
Replaced the word Native with more inclusive words such as built-in. Signed-off-by: Arowa Suliman <arowa@chromium.org> --- doc/code_structure.doxygen | 2 +- doc/driver_wrapper.doxygen | 8 ++++---- doc/p2p.doxygen | 4 ++-- doc/porting.doxygen | 3 ++- wpa_supplicant/ChangeLog | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-)