From patchwork Thu Jul 8 18:23:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arowa Suliman X-Patchwork-Id: 1502658 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Xb1Ey5Ib; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=fsi0WtjM; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GLPpw3D3Yz9sWS for ; Fri, 9 Jul 2021 04:25:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YKcx2gF/6SfUUcx5uWJrrHfrAITvDbJvyCId8B/fp9Q=; b=Xb1Ey5IbHZ7BLE zZ7tt7f+iI1VRXYKDLKh1zSSefZZAL+oSJccOAHFwdtsnUBRC2OCllEDj1qmtQcoHOvHauoXNaxYG grQrVLVYhPEmYIxedmD0aZfcqeSau8Lr3B6xng6nVV70x05O/sGYbDnuVJozriQigwR1dTXqZ8Djm JCNhsSKiH8SJLYiK2gkvXhwMT0G2UJMOy2dF4ptin2pQ8vdHeLi/9DFGsk6HwwgdHP/bnBFxEH7SI tUEKAXRwDfQnrf4f0Dxb78u19JLCCbPEVV9w4OT+ayGZHQ7q174BLiTbY5yk8ZPgZ0c/w/Xh538vI dqmtuWjfUy5gVJOFC/2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1YhK-00047Z-Lf; Thu, 08 Jul 2021 18:24:30 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Yh3-00043T-CA for hostap@lists.infradead.org; Thu, 08 Jul 2021 18:24:14 +0000 Received: by mail-pf1-x42a.google.com with SMTP id q10so6255952pfj.12 for ; Thu, 08 Jul 2021 11:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IUAH2jgY5wVOZIiKFngid61MVHuRsgwO4HTH9luZp7E=; b=fsi0WtjMTus77nh7PESD4bVal+rmFUpA6QVdllQSjavixcSguThNz1IOnrZUfRA7rv utIMimbUf62cobPfHotfA3gNeBjkuw6iQYkvz6tArnt/HNukUmKuz0l2P0GGRpCYSJY/ 0Y7Gi8szCifzj49n0HrEr0uCpoR67RDP/Cs9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IUAH2jgY5wVOZIiKFngid61MVHuRsgwO4HTH9luZp7E=; b=PLEQrBdi6qFCnZI/r6+jMspO+iWWaRnmm9Oc7IvaVhJaiEaQC65SaLuGmflT4VqwX9 8zFpx+NKTzJj7IH10ziMj9JSFg+Hs1uFpfd1UOQ1+ZTpa+9O1X7Pe/bbBXoeo3AiCfII fdU4spIGox6H80pDVdlkCb3d0QakjAu3wrKM1YCefwIYdewQnsf/mFkHCdhAMP2JO4Fi b5KBMXNHmQ67zIczjowOm7LM4YtNglL+94puC9tpGCy6L05CqdMaKKLYg0DBUQLlLwTH 4E44FxrDkpy7VXrI0Q+GPkjHW01Y5wmauPDr7yZjhlQrgJKDMgZX1q5yJ2xNOA9MAO0X fDCg== X-Gm-Message-State: AOAM5308IhAB7I0g1T0hbK2ij4eV5SmFh6bIbgIvdOcK0aU1toyNjRIj JZLmklvh5v2W4Lr1OTUdPF0gTL3gABYo5A== X-Google-Smtp-Source: ABdhPJwDZQx59QNYLrqQte5pduQyJJ1pkA1sBzNaynH/HrQfCyj7AC2SfpHIQVdbvGpdKd5Y40DkqA== X-Received: by 2002:a63:3854:: with SMTP id h20mr24922076pgn.209.1625768652510; Thu, 08 Jul 2021 11:24:12 -0700 (PDT) Received: from arowa.mtv.corp.google.com ([2620:15c:202:201:2d87:d6c4:bee0:a87]) by smtp.gmail.com with ESMTPSA id y6sm3904376pgk.79.2021.07.08.11.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 11:24:12 -0700 (PDT) From: Arowa Suliman X-Google-Original-From: Arowa Suliman To: hostap@lists.infradead.org Cc: Arowa Suliman , Arowa Suliman Subject: [PATCH v3 3/9] wpa_supplicant: src: Replace Sane with Valid. Date: Thu, 8 Jul 2021 11:23:54 -0700 Message-Id: <20210708182400.113748-3-arowa@google.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog In-Reply-To: <20210708182400.113748-1-arowa@google.com> References: <20210708182400.113748-1-arowa@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_112413_441604_2C6A245F X-CRM114-Status: GOOD ( 17.50 ) X-Spam-Score: -0.4 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Replace the word Sane with Valid which is inclusive. Signed-off-by: Arowa Suliman --- src/drivers/driver.h | 4 ++-- src/drivers/driver_common.c | 2 +- src/drivers/driver_nl80211_capa.c | 2 +- wpa_supplicant/wpa_supplicant.c | 2 +- 4 [...] Content analysis details: (-0.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:42a listed in] [list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Replace the word Sane with Valid which is inclusive. Signed-off-by: Arowa Suliman --- src/drivers/driver.h | 4 ++-- src/drivers/driver_common.c | 2 +- src/drivers/driver_nl80211_capa.c | 2 +- wpa_supplicant/wpa_supplicant.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/drivers/driver.h b/src/drivers/driver.h index 804ac6806..4148ab07b 100644 --- a/src/drivers/driver.h +++ b/src/drivers/driver.h @@ -1894,11 +1894,11 @@ struct wpa_driver_capa { */ #define WPA_DRIVER_FLAGS_P2P_MGMT_AND_NON_P2P 0x00002000 /** - * Driver is known to use sane error codes, i.e., when it indicates that + * Driver is known to use valid error codes, i.e., when it indicates that * something (e.g., association) fails, there was indeed a failure and the * operation does not end up getting completed successfully later. */ -#define WPA_DRIVER_FLAGS_SANE_ERROR_CODES 0x00004000 +#define WPA_DRIVER_FLAGS_VALID_ERROR_CODES 0x00004000 /** Driver supports off-channel TX */ #define WPA_DRIVER_FLAGS_OFFCHANNEL_TX 0x00008000 /** Driver indicates TX status events for EAPOL Data frames */ diff --git a/src/drivers/driver_common.c b/src/drivers/driver_common.c index a7ebe9566..1cb976011 100644 --- a/src/drivers/driver_common.c +++ b/src/drivers/driver_common.c @@ -268,7 +268,7 @@ const char * driver_flag_to_string(u64 flag) DF2S(P2P_CAPABLE); DF2S(AP_TEARDOWN_SUPPORT); DF2S(P2P_MGMT_AND_NON_P2P); - DF2S(SANE_ERROR_CODES); + DF2S(VALID_ERROR_CODES); DF2S(OFFCHANNEL_TX); DF2S(EAPOL_TX_STATUS); DF2S(DEAUTH_TX_STATUS); diff --git a/src/drivers/driver_nl80211_capa.c b/src/drivers/driver_nl80211_capa.c index cd596e311..83868b78e 100644 --- a/src/drivers/driver_nl80211_capa.c +++ b/src/drivers/driver_nl80211_capa.c @@ -1389,7 +1389,7 @@ int wpa_driver_nl80211_capa(struct wpa_driver_nl80211_data *drv) WPA_DRIVER_AUTH_SHARED | WPA_DRIVER_AUTH_LEAP; - drv->capa.flags |= WPA_DRIVER_FLAGS_SANE_ERROR_CODES; + drv->capa.flags |= WPA_DRIVER_FLAGS_VALID_ERROR_CODES; drv->capa.flags |= WPA_DRIVER_FLAGS_SET_KEYS_AFTER_ASSOC_DONE; drv->capa.flags |= WPA_DRIVER_FLAGS_EAPOL_TX_STATUS; diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index 0d9b9caa5..89826ca26 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -3868,7 +3868,7 @@ static void wpas_start_assoc_cb(struct wpa_radio_work *work, int deinit) if (ret < 0) { wpa_msg(wpa_s, MSG_INFO, "Association request to the driver " "failed"); - if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_SANE_ERROR_CODES) { + if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_VALID_ERROR_CODES) { /* * The driver is known to mean what is saying, so we * can stop right here; the association will not