From patchwork Wed Jun 23 00:31:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arowa Suliman X-Patchwork-Id: 1495881 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vV/fHyJP; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=oNv1NUkO; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G8klb0FRwz9sS8 for ; Wed, 23 Jun 2021 10:33:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sel4wEgpF+QfirB+SQzxE8Gv0p2S4aBUqffs2+2keyY=; b=vV/fHyJPpVB7j7 vhg+vMS9d3I3UcRrpUZWRqfKulcwyLLld/k95EsQoXaYra6po1gMKBQawkzZo8/YaQUQE49/EV4pD n0Xz6c5c75BcGMvFA1Jig4j5Zo74xrnuPjh4VgkFBG0M+L5z5BCZOogGV1BlTOQTgugeGG03+eY1a 8PLCHhGwTHCPwlo541SIp9y42Y10buP97j5M/nroPssJKlGEkku7jWlQfLAyyOmxyV2UDpBd1owqU fFi9zYXBIFbqudFS5yZpdTRwLnorISmgBvnQIdiyqCjm7jBtvy5VHAcjbbDrD2EtLjSrnnu1VQb8s igCrgtUTmw28LttxncJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvqpB-008qvV-DD; Wed, 23 Jun 2021 00:33:01 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvqos-008qqT-NS for hostap@lists.infradead.org; Wed, 23 Jun 2021 00:32:44 +0000 Received: by mail-pj1-x1035.google.com with SMTP id k5so443687pjj.1 for ; Tue, 22 Jun 2021 17:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rAbzc/Klshyy0NkD7Vau86U8PD3oOjRjlxy0Xm4XZVE=; b=oNv1NUkOHUQQewXuTysr64o2L4b1EaKj8JjifWYceVc8nWPcgJ0qx9J4i0veO9F1vH ijjEUBFxg9HR0DX5KNiGL1fvOGapnRWrDKi1aaTQZrwIKG7lBkpCjzRwSHi6sIck10Bk KzuMWfKZbxODmmJq5huITSWeOHFQIqoDpqHoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rAbzc/Klshyy0NkD7Vau86U8PD3oOjRjlxy0Xm4XZVE=; b=rsKvU799+3RZOKtxD+XKq20FHMVVetTI7fg33EMC4BYQyigDrJ7kNLh+HFDG7gxxxu Fb3VcU/p6NxRScmHI7cTxs6BpwiU4+Ypo9a4yUBNtW4U0D6QSkSBrMPXkkahhSlCwBJl sr3E/TEJe/7rurKmfhC2sNPwMRdVZPmNaNA58jDfUbxNOFqakxnlTw0IDs7eZ0ynIoJP z86lSgl1DDcXmfGi3E3b/rIcl/gBPqww7AMPPNjno7p8kjNAy+broDYM1D7/W14xMCBn osmz8sYwpvlJzTeO9KseT5XkGIGukeVOlJr5Ou+KL8/lvhP2EMsr4yKZhm9DJsZIYZ9n huWA== X-Gm-Message-State: AOAM533IdF+e9B27ZvHv9ZgQ5D6Mjr/YczKm2jcWsdt4PhUJkRXjxFNM A+DTjAnnwDOoka+UjTuzEaVBKIR6cVTkTw== X-Google-Smtp-Source: ABdhPJzsoIGDL0VLbr6l8JJqYlXcV2uxvU5CyB4oP91Y0uAOu7T/kOwOE4xjssSkZhOviM8L8RkP/A== X-Received: by 2002:a17:90a:4404:: with SMTP id s4mr6733362pjg.218.1624408361869; Tue, 22 Jun 2021 17:32:41 -0700 (PDT) Received: from arowa.mtv.corp.google.com ([2620:15c:202:201:fb61:adee:3d97:59de]) by smtp.gmail.com with ESMTPSA id n5sm404437pfv.159.2021.06.22.17.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 17:32:41 -0700 (PDT) From: Arowa Suliman X-Google-Original-From: Arowa Suliman To: hostap@lists.infradead.org Cc: daniel@makrotopia.org, j@w1.fi, Arowa Suliman , Arowa Suliman Subject: [PATCH 4/6] wpa_supplicant: Replace Sanity with Validity. Date: Tue, 22 Jun 2021 17:31:23 -0700 Message-Id: <20210623003125.354448-5-arowa@google.com> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog In-Reply-To: <20210623003125.354448-1-arowa@google.com> References: <20210623003125.354448-1-arowa@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_173242_847450_3DA69C8A X-CRM114-Status: GOOD ( 18.35 ) X-Spam-Score: -0.4 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Replaced the word Sanity with the inclusive word Validity. Signed-off-by: Arowa Suliman --- src/ap/wpa_auth_ft.c | 4 ++-- src/p2p/p2p_pd.c | 2 +- src/pae/ieee802_1x_kay.c | 8 ++++---- tests/hwsim/test_fst_config.py | 2 +- tests/hwsim/test [...] Content analysis details: (-0.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1035 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Replaced the word Sanity with the inclusive word Validity. Signed-off-by: Arowa Suliman --- src/ap/wpa_auth_ft.c | 4 ++-- src/p2p/p2p_pd.c | 2 +- src/pae/ieee802_1x_kay.c | 8 ++++---- tests/hwsim/test_fst_config.py | 2 +- tests/hwsim/test_wmediumd.py | 2 +- wpa_supplicant/ctrl_iface.c | 2 +- wpa_supplicant/p2p_supplicant_sd.c | 4 ++-- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/ap/wpa_auth_ft.c b/src/ap/wpa_auth_ft.c index e80086b93..f91a2d2d5 100644 --- a/src/ap/wpa_auth_ft.c +++ b/src/ap/wpa_auth_ft.c @@ -455,7 +455,7 @@ static int wpa_ft_rrb_lin(const struct tlv_list *tlvs1, pos += wpa_ft_tlv_lin(tlvs2, pos, endpos); pos += wpa_ft_vlan_lin(vlan, pos, endpos); - /* sanity check */ + /* validity check */ if (pos != endpos) { wpa_printf(MSG_ERROR, "FT: Length error building RRB"); goto err; @@ -3590,7 +3590,7 @@ int wpa_ft_action_rx(struct wpa_state_machine *sm, const u8 *data, size_t len) } /* - * Do some sanity checking on the target AP address (not own and not + * Do some validity checking on the target AP address (not own and not * broadcast. This could be extended to filter based on a list of known * APs in the MD (if such a list were configured). */ diff --git a/src/p2p/p2p_pd.c b/src/p2p/p2p_pd.c index 05fd59349..338b47e4e 100644 --- a/src/p2p/p2p_pd.c +++ b/src/p2p/p2p_pd.c @@ -1425,7 +1425,7 @@ void p2p_process_prov_disc_resp(struct p2p_data *p2p, const u8 *sa, * Save the reported channel list and operating frequency. * Note that the specification mandates that the responder * should include in the channel list only channels reported by - * the initiator, so this is only a sanity check, and if this + * the initiator, so this is only a validity check, and if this * fails the flow would continue, although it would probably * fail. Same is true for the operating channel. */ diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c index 2fe88ac0c..7688a00a1 100644 --- a/src/pae/ieee802_1x_kay.c +++ b/src/pae/ieee802_1x_kay.c @@ -3057,11 +3057,11 @@ int ieee802_1x_kay_enable_new_info(struct ieee802_1x_kay *kay) /** - * ieee802_1x_kay_mkpdu_sanity_check - - * Sanity checks specified in IEEE Std 802.1X-2010, 11.11.2 (Validation of + * ieee802_1x_kay_mkpdu_validity_check - + * Validity checks specified in IEEE Std 802.1X-2010, 11.11.2 (Validation of * MKPDUs) */ -static int ieee802_1x_kay_mkpdu_sanity_check(struct ieee802_1x_kay *kay, +static int ieee802_1x_kay_mkpdu_validity_check(struct ieee802_1x_kay *kay, const u8 *buf, size_t len) { struct ieee8023_hdr *eth_hdr; @@ -3215,7 +3215,7 @@ static int ieee802_1x_kay_decode_mkpdu(struct ieee802_1x_kay *kay, wpa_printf(MSG_DEBUG, "KaY: Decode received MKPDU (ifname=%s)", kay->if_name); - if (ieee802_1x_kay_mkpdu_sanity_check(kay, buf, len)) + if (ieee802_1x_kay_mkpdu_validity_check(kay, buf, len)) return -1; /* handle basic parameter set */ diff --git a/tests/hwsim/test_fst_config.py b/tests/hwsim/test_fst_config.py index 981340141..66b5a729c 100644 --- a/tests/hwsim/test_fst_config.py +++ b/tests/hwsim/test_fst_config.py @@ -269,7 +269,7 @@ def parse_ies(iehex, el=-1): iel = [iehex[i:i + 2] for i in range(0, len(iehex), 2)] for i in range(0, len(iel)): iel[i] = int(iel[i], 16) - # Sanity check + # Validity check i = 0 res = [] while i < len(iel): diff --git a/tests/hwsim/test_wmediumd.py b/tests/hwsim/test_wmediumd.py index ad38f03ce..8243e7ce3 100644 --- a/tests/hwsim/test_wmediumd.py +++ b/tests/hwsim/test_wmediumd.py @@ -1,4 +1,4 @@ -# wmediumd sanity checks +# wmediumd validity checks # Copyright (c) 2015, Intel Deutschland GmbH # # This software may be distributed under the terms of the BSD license. diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index 4e8b30aba..2b3243e5a 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -5918,7 +5918,7 @@ static struct p2ps_provision * p2p_parse_asp_provision_cmd(const char *cmd) for (i = 0; p2ps_prov->cpt_priority[i]; i++) p2ps_prov->cpt_mask |= p2ps_prov->cpt_priority[i]; - /* force conncap with tstCap (no sanity checks) */ + /* force conncap with tstCap (no validity checks) */ pos = os_strstr(cmd, "tstCap="); if (pos) { role = strtol(pos + 7, NULL, 16); diff --git a/wpa_supplicant/p2p_supplicant_sd.c b/wpa_supplicant/p2p_supplicant_sd.c index f8675e68b..b400cbaca 100644 --- a/wpa_supplicant/p2p_supplicant_sd.c +++ b/wpa_supplicant/p2p_supplicant_sd.c @@ -826,7 +826,7 @@ static void wpas_sd_p2ps_serv_response(struct wpa_supplicant *wpa_s, size_t buf_len; u8 svc_len; - /* Sanity check fixed length+svc_str */ + /* Validity check fixed length+svc_str */ if (6 >= tlv_end - pos) break; svc_len = pos[6]; @@ -854,7 +854,7 @@ static void wpas_sd_p2ps_serv_response(struct wpa_supplicant *wpa_s, buf_len = WPA_GET_LE16(pos); pos += sizeof(u16); - /* Sanity check buffer length */ + /* Validity check buffer length */ if (buf_len > (unsigned int) (tlv_end - pos)) break;