diff mbox series

[1/9] supplicant: Update HS20 readme.

Message ID 20200207091017.26244-1-greearb@candelatech.com
State Changes Requested
Headers show
Series [1/9] supplicant: Update HS20 readme. | expand

Commit Message

Ben Greear Feb. 7, 2020, 9:10 a.m. UTC 
From: Ben Greear <greearb@candelatech.com>

Mention dependencies needed to properly implement HS20.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 wpa_supplicant/README-HS20 | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jouni Malinen Feb. 16, 2020, 1:41 p.m. UTC | #1 
On Fri, Feb 07, 2020 at 01:10:09AM -0800, greearb@candelatech.com wrote:
> Mention dependencies needed to properly implement HS20.
> diff --git a/wpa_supplicant/README-HS20 b/wpa_supplicant/README-HS20
> @@ -70,6 +70,12 @@ There are number of run-time configuration parameters (e.g., in
>  wpa_supplicant.conf when using the configuration file) that can be used
>  to control Hotspot 2.0 operations.
>  
> +
> +Requirements & Limitations in hostapd implementation:

This file is about wpa_supplicant, so a note about hostapd in this
context feels a bit strange.

> + *  HotSpot 2.0 requires interworking.
> + *  Interworking requires WPA2-Enterprise/EAPOL (802.1x) authentication.
> +
> +
>  # Enable Interworking
>  interworking=1

Why would Interworking need to be mentioned just before this place where
it is explicitly?

What is the purpose of mentioning WPA2-Enterprise here? Interworking (as
defined in IEEE Std 802.11-2016) does not "require" EAP authentication,
so that statement on its own is misleading. Anyway, I don't see how any
of this would help in wpa_supplicant/README-HS20.
diff mbox series

Patch

diff --git a/wpa_supplicant/README-HS20 b/wpa_supplicant/README-HS20
index 334287101..481e8cf2a 100644
--- a/wpa_supplicant/README-HS20
+++ b/wpa_supplicant/README-HS20
@@ -70,6 +70,12 @@  There are number of run-time configuration parameters (e.g., in
 wpa_supplicant.conf when using the configuration file) that can be used
 to control Hotspot 2.0 operations.
 
+
+Requirements & Limitations in hostapd implementation:
+ *  HotSpot 2.0 requires interworking.
+ *  Interworking requires WPA2-Enterprise/EAPOL (802.1x) authentication.
+
+
 # Enable Interworking
 interworking=1