From patchwork Mon Dec 5 13:42:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 129286 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "maxx.shmoo.com", Issuer "CA Cert Signing Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id BE20B1007D4 for ; Tue, 6 Dec 2011 00:42:21 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id E344B9C247; Mon, 5 Dec 2011 08:42:15 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u63GP2-UzBBP; Mon, 5 Dec 2011 08:42:15 -0500 (EST) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id A010E9C210; Mon, 5 Dec 2011 08:42:11 -0500 (EST) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id E663B9C210 for ; Mon, 5 Dec 2011 08:42:10 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s-wR9VNdxPfQ for ; Mon, 5 Dec 2011 08:42:06 -0500 (EST) Received: from sipsolutions.net (he.sipsolutions.net [78.46.109.217]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by maxx.maxx.shmoo.com (Postfix) with ESMTPS id 0AB139C188 for ; Mon, 5 Dec 2011 08:42:05 -0500 (EST) Received: by sipsolutions.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.77) (envelope-from ) id 1RXYnz-0001PN-HO; Mon, 05 Dec 2011 14:42:03 +0100 Subject: Re: [PATCH v4 10/15] driver_nl80211: use nl80211 for mgmt TX/RX in AP mode From: Johannes Berg To: Jouni Malinen In-Reply-To: <20111203183940.GH24517@jm.kir.nu> References: <20111119123910.783418920@sipsolutions.net> <20111119123952.403374239@sipsolutions.net> <1321872113.3999.37.camel@jlt3.sipsolutions.net> <20111203183940.GH24517@jm.kir.nu> Date: Mon, 05 Dec 2011 14:42:02 +0100 Message-ID: <1323092522.4051.36.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Cc: hostap@lists.shmoo.com X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com On Sat, 2011-12-03 at 20:39 +0200, Jouni Malinen wrote: > 1322937312.602354: nl80211: Setup AP operations for P2P group (GO) > 1322937312.602372: nl80211: Set mode ifindex 3 iftype 9 (P2P_GO) > 1322937312.603544: nl80211: Register frame command failed (type=64): ret=-114 (Operation already in progress) > 1322937312.603596: nl80211: Register frame match - hexdump(len=0): [NULL] > 1322937312.603753: wlan0: Failed to start AP functionality So this is indeed starting a GO while probe request reporting is enabled, the easiest and probably best fix too seems to just disable it unconditionally, see below. I'll roll that into this patch and investigate the other bug. johannes --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -5602,6 +5602,13 @@ static int nl80211_setup_ap(struct i802_bss *bss) { struct wpa_driver_nl80211_data *drv = bss->drv; + /* + * Disable probe request reporting unless we may need it, + * we'll enable it through the nl_mgmt socket instead. + */ + if (!drv->device_ap_sme) + wpa_driver_nl80211_probe_req_report(bss, 0); + if (!drv->device_ap_sme && !drv->use_monitor) if (nl80211_mgmt_subscribe_ap(bss)) return -1;