mbox series

[v2,00/20] Various mostly WNM related fixes and cleanups

Message ID 20240220131827.17766-1-benjamin@sipsolutions.net
Headers show
Series Various mostly WNM related fixes and cleanups | expand

Message

Benjamin Berg Feb. 20, 2024, 1:18 p.m. UTC 
From: Benjamin Berg <benjamin@sipsolutions.net>

This is an updated series of the previous patchset. I have thrown in a
few more general cleanup patches at the start, this is mostly to unify
the code in order to use the valid_links pattern and adding a generic
iteration macro.

On the WNM side, I added more patches to cleanup the code and logic a
bit more. I am planning to build on that to handle the ABRIDGED bit
properly and unify the BSS selection code more.

Avraham Stern (1):
  WNM: Wait for BTM response tx status before roaming

Benjamin Berg (18):
  tests: Add missing scan cache flush
  nl80211: Fix link indexing in nl80211_connect_common
  common: Introduce for_each_link macro
  Use for_each_link in most cases
  Use for_each_link where possible
  nl80211: Use valid_links bitmask for bss->links array
  BSS: Switch struct wpa_bss to use valid_links bitmask
  WNM: Clean up old scan data processing
  WNM: Don't scan frequencies of neighbors that should be ignored
  WNM: Define a stub wnm_is_bss_excluded if WNM is disabled
  WNM: Drop check for current_ssid
  WNM: Drop explicit SSID check
  WNM: Drop explicit wpa_is_bss_tmp_disallowed check
  WNM: Do not store coloc_intf_elems
  WNM: Set wnm_reply to 0 when sending it
  WNM: Remove dialog_token parameter
  WNM: Follow BTM procedure if last link is dropped
  WNM: Keep BTM information until connection completes

Ilan Peer (1):
  nl80211: Explicitly differentiate between 5GHz mode and 6GHz mode

 src/ap/hw_features.c               |   8 +-
 src/ap/wpa_auth.c                  |   5 +-
 src/drivers/driver.h               |   5 +
 src/drivers/driver_nl80211.c       | 237 ++++++------------
 src/drivers/driver_nl80211.h       |  29 ++-
 src/drivers/driver_nl80211_capa.c  |  11 +-
 src/drivers/driver_nl80211_event.c |  47 ++--
 src/rsn_supp/tdls.c                |   6 +-
 src/rsn_supp/wpa.c                 |  23 +-
 src/utils/common.h                 |  12 +
 tests/hwsim/test_ap_hs20.py        |   1 +
 wpa_supplicant/bss.c               |  38 ++-
 wpa_supplicant/bss.h               |   5 +-
 wpa_supplicant/ctrl_iface.c        |  12 +-
 wpa_supplicant/events.c            |  40 ++-
 wpa_supplicant/rrm.c               |   5 +-
 wpa_supplicant/scan.c              |   5 +-
 wpa_supplicant/sme.c               |  39 ++-
 wpa_supplicant/wnm_sta.c           | 374 +++++++++++++----------------
 wpa_supplicant/wnm_sta.h           |  29 ++-
 wpa_supplicant/wpa_supplicant.c    |  28 +--
 wpa_supplicant/wpa_supplicant_i.h  |   4 +-
 22 files changed, 423 insertions(+), 540 deletions(-)

Comments

Jouni Malinen March 2, 2024, 10:31 a.m. UTC | #1 
On Tue, Feb 20, 2024 at 02:18:07PM +0100, benjamin@sipsolutions.net wrote:
> This is an updated series of the previous patchset. I have thrown in a
> few more general cleanup patches at the start, this is mostly to unify
> the code in order to use the valid_links pattern and adding a generic
> iteration macro.

I applied this part first with some cleanup and fixes, and with the
seemingly unrelated CTRL-EVENT-CONNECTED change removed.
Jouni Malinen March 2, 2024, 7:16 p.m. UTC | #2 
On Tue, Feb 20, 2024 at 02:18:07PM +0100, benjamin@sipsolutions.net wrote:
> On the WNM side, I added more patches to cleanup the code and logic a
> bit more. I am planning to build on that to handle the ABRIDGED bit
> properly and unify the BSS selection code more.

Thanks, applied with some cleanup and fixes.