From patchwork Mon Aug 1 14:46:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 1662635 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=HETKa8kO; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LxLY35kzcz9sGP for ; Tue, 2 Aug 2022 00:46:31 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D05AF385842B for ; Mon, 1 Aug 2022 14:46:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D05AF385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659365188; bh=l1iRuKRy7YAhDWrqYmkJP6ntPkPulPCa7T/iAGxOneE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=HETKa8kOtqWl1g5+JjQ2tqL9a5y+iK4vaU2TWBYHV3aUZ0QKiF2Aflfi6B4mN9yKM 10NeRQMjMuaH4MUAeCJsII02QvGwmOJ9xj0zJ/epG3PvjNbZxZfY/2NDLDyycqy6W3 x6w1oCkH55P5HV26ea1e2qTB3ynMHPJYK7gWq5HM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id D788F3858D39 for ; Mon, 1 Aug 2022 14:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D788F3858D39 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1DCBC352CC for ; Mon, 1 Aug 2022 14:46:14 +0000 (UTC) Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 190122C141 for ; Mon, 1 Aug 2022 14:46:14 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id F2BE7444B21; Mon, 1 Aug 2022 16:46:13 +0200 (CEST) To: libc-alpha@sourceware.org Subject: [PATCH] Don't use unsupported format string in ld.so (bug 29427) X-Yow: I can't decide which WRONG TURN to make first!! I wonder if BOB GUCCIONE has these problems! Date: Mon, 01 Aug 2022 16:46:13 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.90 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andreas Schwab via Libc-alpha From: Andreas Schwab Reply-To: Andreas Schwab Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" There is no support for printf format strings that contain a literal field width or precision in the dynamic loader, they have to be specified indirectly. Reviewed-by: Florian Weimer --- elf/dl-diagnostics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-diagnostics.c b/elf/dl-diagnostics.c index dd3871b1e0..269c428c93 100644 --- a/elf/dl-diagnostics.c +++ b/elf/dl-diagnostics.c @@ -108,7 +108,7 @@ _dl_diagnostics_print_labeled_value (const char *label, uint64_t value) if (high == 0) _dl_printf ("%s=0x%x\n", label, low); else - _dl_printf ("%s=0x%x%08x\n", label, high, low); + _dl_printf ("%s=0x%x%0*x\n", label, high, 8, low); } }