From patchwork Tue Jul 30 04:51:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Flavio Cruz X-Patchwork-Id: 1966310 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=lIYfZZZS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WY2rH1NPxz1ybX for ; Tue, 30 Jul 2024 14:51:43 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18B48385C6C7 for ; Tue, 30 Jul 2024 04:51:40 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 516E13858C3A for ; Tue, 30 Jul 2024 04:51:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 516E13858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 516E13858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::730 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722315087; cv=none; b=MdBm/E9usZr4rCFDemrOxUnJuBGvnYbT2V2b66vvVhijq8dHN5pOV4fHlKkJraS/oSiuk01itrae8bcji2Qwo0ey7oyd5WZnL6OL0QQNT/OCPItzQvmuAuh8taPwm2YPiK6zZeh6XiZeklki4zOiWpiDOlnqZ/CSRzzlosQcrrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722315087; c=relaxed/simple; bh=8EoLaWI0kv9MH3H+J2ued8Js9wZkaIu4iop7es1/hj4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=UabVTqh4F9Dgp7p5lFtcJEW/kzI7OANF1o6bsxAGS4agakfxDaq6e/V5XiiJVTi9Hz5V4X8lJIahqkcPaESwq4cTbjOiRAhXGlErPJnuLq4sDw483d0hTHhvxttE4XPwyEkPKJnkaWph3r9hJL+Ef0St/FC/7genFv1bLRbhapU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-7a1d984ed52so234316685a.0 for ; Mon, 29 Jul 2024 21:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722315084; x=1722919884; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=5GjgY7r3mI5gzTE066aJCU8MWGo1YpDRvjCSF5niT7w=; b=lIYfZZZSUiU0d0lA56N7BazvlvpR7pCJUdrE4mI3RgVREL/6lVQGGejMuM7L9M0grl xZvYppiCGZH80i28QSGYRjOhPiFC2S3/ywY6QMbW8Hm5ZdomAQBnr2/3xLx4omazbY6r 9nUaZyrEJkLRMboHsdXG9xiorLcKWECIgfUHaCC4QsIn379aiiZ0HcBh7/Z1fXNIH4DC KUuXFKzi2djcg6tnLc45XpZk8WKuhvUaPFVHbO1tLkXKRqsaqHtUpAwxWX32CHwo8D3g ozw2R4iTtLhK+x+IYd+8x5Xzlg45zXrZGRLwWE0/iQHaaet3B+0lNk8fo6ir8FYBEWOF isKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722315084; x=1722919884; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GjgY7r3mI5gzTE066aJCU8MWGo1YpDRvjCSF5niT7w=; b=VvxoZm9I49uZKNooXOeCtbA+isDoCVNNXEk6H8idtQOdh9TocknBc9A7pqauVMRQAT 0BdVyYiXq6Kge9oNjBGYrTVlzNegxAhwHXyKrlAzr8WQYa3AMI4JdCAw1Xk4wOCT0hcv +lEXoL4fN5h6x4GqyuHz37MDQmzMshl+zdaQRl9ACQNOX9JrKpWeGhyCAm/zl349b3W1 QR/lVUY4p23NdYVyFV3h8vjKDO9tVB7BndDMmH9GUBzj9gSYoaPipndw1OepwIVCHKQ1 p2KQnT3MPwfyCA10apzLRe9qzUkvQo5A6n5mGGSr1tnhtSDQzHFPgauST6fM+xB5T79y N2jA== X-Forwarded-Encrypted: i=1; AJvYcCVCnJ2oWjNlln/V6MloblT341RR0rzvyuv2GKdzHxXM16Ic36r2WmEJKqxks9+YTO17/95fTvZYClQ3oK5g/XU7kUVS102do6ZL X-Gm-Message-State: AOJu0Yz52mHmw/ukd6EZBW2tGnW2S5CL6z+s97IXGZ2rwulgsYVJ/hrx ABA47/KNUUTog1RVauSYBLkzAEF1TJG+Bw9zOBMT3MI/ul3l1+s= X-Google-Smtp-Source: AGHT+IHuuElSLzSgYhCmhUna8TRpyWwN45LWfXZuWgBXP8J3l6wwqVQLtIowkj5Z3+r8xD5tWgq1jQ== X-Received: by 2002:a05:620a:27c5:b0:7a1:c431:3412 with SMTP id af79cd13be357-7a1e526b31fmr952668685a.38.1722315083549; Mon, 29 Jul 2024 21:51:23 -0700 (PDT) Received: from localhost ([24.154.253.225]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1e146a506sm461156985a.4.2024.07.29.21.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 21:51:23 -0700 (PDT) Date: Tue, 30 Jul 2024 00:51:20 -0400 From: Flavio Cruz To: bug-hurd , libc-alpha Subject: [PATCH] x86_64 hurd: ensure we have a large enough buffer to receive exception_raise requests. Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org --- This is likely to help with some of the issues we are seeing with x86_64 related to signal handling but I don't know how to reproduce it. hurd/hurdfault.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hurd/hurdfault.c b/hurd/hurdfault.c index 5110c6030f..1fe973f54d 100644 --- a/hurd/hurdfault.c +++ b/hurd/hurdfault.c @@ -121,7 +121,14 @@ faulted (void) struct { mach_msg_header_t head; - char buf[64]; + /* This is the size of the exception_raise request + * including mach_msg_header_t. + * See generated code in faultexc_server.c. */ +#ifdef __LP64__ + char buf[112]; +#else + char buf[64]; +#endif } request; mig_reply_header_t reply; extern int _hurdsig_fault_exc_server (mach_msg_header_t *,