diff mbox

[09/25] grp: Rewrite to use struct scratch_buffer instead of extend_alloca

Message ID d8020928bdb9deae3f1bc661744ffb90d1a0e40e.1425285061.git.fweimer@redhat.com
State New
Headers show

Commit Message

Florian Weimer March 1, 2015, 3:08 p.m. UTC 
grp/compat-initgroups.c is included from nscd/initgrcache.c, which is
why the #include directive has to be added there as well.
---
 grp/compat-initgroups.c | 26 ++++++++------------------
 grp/initgroups.c        |  2 +-
 nscd/initgrcache.c      |  1 +
 3 files changed, 10 insertions(+), 19 deletions(-)

Comments

Ondřej Bílka April 3, 2015, 4:33 p.m. UTC | #1 
On Sun, Mar 01, 2015 at 04:08:58PM +0100, Florian Weimer wrote:
> grp/compat-initgroups.c is included from nscd/initgrcache.c, which is
> why the #include directive has to be added there as well.
> ---
>  grp/compat-initgroups.c | 26 ++++++++------------------
>  grp/initgroups.c        |  2 +-
>  nscd/initgrcache.c      |  1 +
>  3 files changed, 10 insertions(+), 19 deletions(-)
> 
ok
diff mbox

Patch

diff --git a/grp/compat-initgroups.c b/grp/compat-initgroups.c
index ff10e24..3dd50d2 100644
--- a/grp/compat-initgroups.c
+++ b/grp/compat-initgroups.c
@@ -14,7 +14,6 @@  compat_call (service_user *nip, const char *user, gid_t group, long int *start,
 	     long int *size, gid_t **groupsp, long int limit, int *errnop)
 {
   struct group grpbuf;
-  size_t buflen = __sysconf (_SC_GETGR_R_SIZE_MAX);
   enum nss_status status;
   set_function setgrent_fct;
   get_function getgrent_fct;
@@ -35,30 +34,22 @@  compat_call (service_user *nip, const char *user, gid_t group, long int *start,
 
   endgrent_fct = __nss_lookup_function (nip, "endgrent");
 
-  char *tmpbuf = __alloca (buflen);
-  bool use_malloc = false;
+  struct scratch_buffer tmpbuf;
+  scratch_buffer_init (&tmpbuf);
   enum nss_status result = NSS_STATUS_SUCCESS;
 
   do
     {
       while ((status = DL_CALL_FCT (getgrent_fct,
-				     (&grpbuf, tmpbuf, buflen, errnop)),
+				     (&grpbuf, tmpbuf.data, tmpbuf.length,
+				      errnop)),
 	      status == NSS_STATUS_TRYAGAIN)
 	     && *errnop == ERANGE)
         {
-	  if (__libc_use_alloca (buflen * 2))
-	    tmpbuf = extend_alloca (tmpbuf, buflen, buflen * 2);
-	  else
+	  if (!scratch_buffer_grow (&tmpbuf))
 	    {
-	      buflen *= 2;
-	      char *newbuf = realloc (use_malloc ? tmpbuf : NULL, buflen);
-	      if (newbuf == NULL)
-		{
-		  result = NSS_STATUS_TRYAGAIN;
-		  goto done;
-		}
-	      use_malloc = true;
-	      tmpbuf = newbuf;
+	      result = NSS_STATUS_TRYAGAIN;
+	      goto done;
 	    }
         }
 
@@ -116,8 +107,7 @@  compat_call (service_user *nip, const char *user, gid_t group, long int *start,
   while (status == NSS_STATUS_SUCCESS);
 
  done:
-  if (use_malloc)
-    free (tmpbuf);
+  scratch_buffer_free (&tmpbuf);
 
   if (endgrent_fct)
     DL_CALL_FCT (endgrent_fct, ());
diff --git a/grp/initgroups.c b/grp/initgroups.c
index 4d083ac..14a8ab1 100644
--- a/grp/initgroups.c
+++ b/grp/initgroups.c
@@ -15,7 +15,6 @@ 
    License along with the GNU C Library; if not, see
    <http://www.gnu.org/licenses/>.  */
 
-#include <alloca.h>
 #include <assert.h>
 #include <errno.h>
 #include <grp.h>
@@ -26,6 +25,7 @@ 
 #include <sys/param.h>
 #include <sys/types.h>
 #include <nsswitch.h>
+#include <scratch_buffer.h>
 
 #include "../nscd/nscd-client.h"
 #include "../nscd/nscd_proto.h"
diff --git a/nscd/initgrcache.c b/nscd/initgrcache.c
index 7ba76be..e45d65c 100644
--- a/nscd/initgrcache.c
+++ b/nscd/initgrcache.c
@@ -24,6 +24,7 @@ 
 #include <time.h>
 #include <unistd.h>
 #include <sys/mman.h>
+#include <scratch_buffer.h>
 
 #include "dbg_log.h"
 #include "nscd.h"