From patchwork Wed Oct 25 07:36:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 830123 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-86322-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="N3M9+TPX"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yMMR764pfz9sRW for ; Wed, 25 Oct 2017 18:37:07 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; q=dns; s=default; b=IdmUhFJB n2pAGQODVxhhFC0iHXpFAMAhEGJWvdZij1Fy8WIdv5T3lorkRzOi0Ni5Mxd1D3HP xK11RdYdwG/wgNwIdP5mM206xH4LqePjrgNhyMSOjxa3sFjesW/Rlcq5vtLVvBUY EdNu2/W+xPa4j62kbsrFomfahtEUdo307Ng= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; s=default; bh=Zgi9MGpQWl1HN6 TTe5bPWw4kR3E=; b=N3M9+TPXUcZzLLeRjHeWwTOmbJd8ku95pj2jVDssV4Tg2n vn0QeessgEv7IwoCXmGeq3shMIPdCn1NaY9RQct7u4TIF8LXkb4TsgZpidOj7rD2 LBP0k/5oiNzkPnmn6lcN+APV1lKGihMiglqzdz+Y3Gd390aasrxAOZpLf/OWg= Received: (qmail 32196 invoked by alias); 25 Oct 2017 07:36:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 32153 invoked by uid 89); 25 Oct 2017 07:36:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=z09pTgf+Y+J8Ec4dmuSnO6tKIvcCCRPeryf7RIgkZhQ=; b=jseFdu4w6vXg6RQnmNlTz9tHV5Bu/s97YhpPQM3QA0igq4UGhMc3BP96eVLEX56f/5 UfzgmZXOBJVEGMex8TL5NAxjTDCRPtEkLMgPvzWT8H4X7mzak/xsfgAId/3a74J/tSUO gnR3EtUyIMfXoQU7CdN9YYP3BZ/KiWOvliJDDHBUoNqC+CyGdVpBDuPtLTLGXBV3LIqT 9kcegTElnePS0dKkxrnHjrMLw5+yLo7lT7N9xF0xKae8tR9f+cW+lVPEAlxaoJVd5dKw RmkYml6zTVK9Vh0vwNLrF8rwPKHDMpaDzAJE8MDxNxJy9ZtTJ/PMKJxZmU9rvHUvM9rL uiIA== X-Gm-Message-State: AMCzsaVsodwiDFMlVB/qPBPaC5xunIZXWW/cE02quwy6mdMdo6PwXjtF j1mbJ1FlqY47iVHwZzQWSv5bTQ== X-Google-Smtp-Source: ABhQp+RGH/LuZ2pimtT7y7M00XsnroBzY5HfFGFYZuDq9Ri6TE7N+ceFC+FHWIXn3D9VufFxI+mooA== X-Received: by 10.84.235.69 with SMTP id g5mr1068352plt.239.1508917001886; Wed, 25 Oct 2017 00:36:41 -0700 (PDT) From: Alan Modra To: libc-alpha@sourceware.org Cc: Alan Modra Subject: [PATCH 1/7] [PowerPC64] Don't define __GI_ variant of isnan for static lib Date: Wed, 25 Oct 2017 18:06:18 +1030 Message-Id: In-Reply-To: References: In-Reply-To: References: It seems to me that libc.a should not contain any of the __GI_ symbols, and certainly --enable-multi-arch ought to not add to the list. At the end of this patch series we have the following in both --enable-multi-arch and --disable-multi-arch libc.a: 0000000000000000 T __GI___readdir64 0000000000000000 T __GI___fxstatat64 0000000000000000 T __GI_getrlimit 0000000000000000 T __GI___getrlimit * sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S (hidden_def): Redefine only when SHARED. Reviewed-by: Adhemerval Zanella diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S index eba0d4f..fe2d4f1 100644 --- a/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/s_isnan-ppc64.S @@ -28,8 +28,10 @@ #define __isnan __isnan_ppc64 -#undef hidden_def -#define hidden_def(name) \ - .globl __GI___isnan ; .set __GI___isnan,__isnan_ppc64 +#ifdef SHARED + #undef hidden_def + #define hidden_def(name) \ + .globl __GI___isnan ; .set __GI___isnan,__isnan_ppc64 +#endif #include