@@ -1,3 +1,7 @@
+2019-02-11 Carlos O'Donell <carlos@redhat.com>
+
+ * nptl/pthread_tryjoin.c: Fix comment.
+
2019-02-15 Joseph Myers <joseph@codesourcery.com>
* sunrpc/tst-svc_register.c (rpcbind_address): Remove qualifier
@@ -26,7 +26,7 @@ pthread_tryjoin_np (pthread_t threadid, void **thread_return)
if (pd->tid != 0)
return EBUSY;
- /* If pd->tid != 0 then lll_wait_tid will not block on futex
+ /* If pd->tid == 0 then lll_wait_tid will not block on futex
operation. */
return __pthread_timedjoin_ex (threadid, thread_return, NULL, false);
}
After Adhemerval's cleanup the only remaining comment fix is this one and I've just committed it because it's obviously correct. Cheers, Carlos. 8< In pthread_tryjoin if pd->tid == 0 then we will not block on a futex operation because we will immediately see the join is already complete and return. The comment is fixed to reflect that. Signed-off-by: Carlos O'Donell <carlos@redhat.com> --- ChangeLog | 4 ++++ nptl/pthread_tryjoin.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)