| Message ID | ZmxJjATgysCRBP5v@mbp-m3-centos.vm |
|---|---|
| State | New |
| Headers | show |
| Series | signal/Makefile: Split and sort tests | expand |
Hi Michel, Thanks for the patch! This looks good to me. Reviewed-by: Arjun Shankar <arjun@redhat.com> I'll push it in a bit. > From e6d37f761df90d97fa9ae7ffa629fa91ca0ee072 Mon Sep 17 00:00:00 2001 > From: Michel Lind <salimma@fedoraproject.org> > Date: Fri, 14 Jun 2024 15:38:08 +0200 > Subject: [PATCH 1/1] signal/Makefile: Split and sort tests > To: libc-alpha@sourceware.org > Cc: arjun@redhat.com > > This will make it easier to add tests later; see also the test section > in malloc/Makefile that inspires this. > > Signed-off-by: Michel Lind <salimma@fedoraproject.org> > Suggested-by: Arjun Shankar <arjun@redhat.com> OK. > diff --git a/signal/Makefile b/signal/Makefile > index e8e3dce0cf..7cddbc3c65 100644 > --- a/signal/Makefile > +++ b/signal/Makefile > @@ -46,11 +46,22 @@ routines := signal raise killpg \ > allocrtsig sigtimedwait sigwaitinfo sigqueue \ > sighold sigrelse sigignore sigset > > -tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \ > - tst-sigwait-eintr tst-sigaction \ > - tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \ > - tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \ > - tst-sigisemptyset > +tests := \ > + tst-minsigstksz-1 \ > + tst-minsigstksz-2 \ > + tst-minsigstksz-3 \ > + tst-minsigstksz-3a \ > + tst-minsigstksz-4 \ > + tst-minsigstksz-5 \ > + tst-raise \ > + tst-sigaction \ > + tst-sigisemptyset \ > + tst-signal \ > + tst-sigset \ > + tst-sigset2 \ > + tst-sigsimple \ > + tst-sigwait-eintr \ > +# tests OK.
diff --git a/signal/Makefile b/signal/Makefile index e8e3dce0cf..7cddbc3c65 100644 --- a/signal/Makefile +++ b/signal/Makefile @@ -46,11 +46,22 @@ routines := signal raise killpg \ allocrtsig sigtimedwait sigwaitinfo sigqueue \ sighold sigrelse sigignore sigset -tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \ - tst-sigwait-eintr tst-sigaction \ - tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \ - tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \ - tst-sigisemptyset +tests := \ + tst-minsigstksz-1 \ + tst-minsigstksz-2 \ + tst-minsigstksz-3 \ + tst-minsigstksz-3a \ + tst-minsigstksz-4 \ + tst-minsigstksz-5 \ + tst-raise \ + tst-sigaction \ + tst-sigisemptyset \ + tst-signal \ + tst-sigset \ + tst-sigset2 \ + tst-sigsimple \ + tst-sigwait-eintr \ +# tests include ../Rules
This will make it easier to add tests later; see also the test section in malloc/Makefile that inspires this. Signed-off-by: Michel Lind <salimma@fedoraproject.org> Suggested-by: Arjun Shankar <arjun@redhat.com> --- signal/Makefile | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)