diff mbox series

[v2] Build libsupport.a with exception and asynchronous unwind tables

Message ID ZJ9dNnae4Xg32Txb@mx3210.localdomain
State New
Headers show
Series [v2] Build libsupport.a with exception and asynchronous unwind tables | expand

Commit Message

John David Anglin June 30, 2023, 10:54 p.m. UTC 
The attached change fixes the nptl/tst-cleanupx4 test on hppa. Version
2 uses "CFLAGS-.oS" as suggested.

Okay to install?

Dave
---

support: Build with exceptions and asynchronous unwind tables [BZ #30587]

Changing tst-cleanup4.c to use xread instead of read caused
the nptl/tst-cleanupx4 test to fail.  The routines in libsupport.a
need to be built with exception handling and asynchronous unwind
table support.

v2: Use "CFLAGS-.oS" instead of "override CFLAGS".

Comments

Florian Weimer July 1, 2023, 9:41 a.m. UTC | #1 
* John David Anglin:

> The attached change fixes the nptl/tst-cleanupx4 test on hppa. Version
> 2 uses "CFLAGS-.oS" as suggested.
>
> Okay to install?

Yes, please.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
diff mbox series

Patch

diff --git a/support/Makefile b/support/Makefile
index c81e3c928c..917a858bd1 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -239,6 +239,9 @@  CFLAGS-support_paths.c = \
 		-DCOMPLOCALEDIR_PATH=\"$(complocaledir)\" \
 		-DSYSCONFDIR_PATH=\"$(sysconfdir)\"
 
+# Build with exception handling and asynchronous unwind table support.
+CFLAGS-.oS += -fexceptions -fasynchronous-unwind-tables
+
 # In support_timespec_check_in_range we may be passed a very tight
 # range for which we should produce a correct result for expected
 # being within the observed range.  The code uses double internally