From patchwork Sat Jan 24 00:22:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 432350 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9E2B9140180 for ; Sat, 24 Jan 2015 11:22:53 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; q=dns; s=default; b= tqTqoW0zT+2yybqmkhLMTkc5exj0l1FaB2mdNxDwstSuDkpxSHqgotnzlVGyGrUQ dOxU9d8U/fJHDLmiqWWt4PfQsFQ8ixGJTmuoiShtJj8fTf2WsL7XZvNySVPgt58n bsZbj50coPFxLxV7wo4nUYb8FXRDxPlpbIAN002BGks= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; s=default; bh=Pq/tL FGafj2Nq4Ltoi2xQu3XzoE=; b=orV6heenaTIJ41Jy9dLYG3kdPx0KLAVbWY5LI njZoLNbcgX/mn/0ChhszSNnO+ItE5A95xlVf47y10F3Z3BTnLficH0Ou4jmky8Or eaB2PjkWViIhJhmB8pyGyJEy7MPA2geugps2RR+XFmncDuvXZbOTV5d+m5lSbqaf 7oXsaU= Received: (qmail 11860 invoked by alias); 24 Jan 2015 00:22:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 11851 invoked by uid 89); 24 Jan 2015 00:22:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f43.google.com MIME-Version: 1.0 X-Received: by 10.60.156.196 with SMTP id wg4mr6199556oeb.11.1422058963167; Fri, 23 Jan 2015 16:22:43 -0800 (PST) In-Reply-To: References: <54C2BDD7.7000304@redhat.com> <54C2D593.4060503@ezchip.com> Date: Fri, 23 Jan 2015 16:22:43 -0800 Message-ID: Subject: Re: glibc 2.21 - Machine maintainers, please test your machines. From: "H.J. Lu" To: Chris Metcalf Cc: "Carlos O'Donell" , GNU C Library , David Miller , Richard Henderson , Mike Frysinger , Andreas Schwab , "Joseph S. Myers" , Kaz Kojima , Thomas Schwinge , Marcus Shawcroft , David Holsgrove , Chung-Lin Tang , Adhemerval Zanella , Andreas Krebbel On Fri, Jan 23, 2015 at 4:11 PM, H.J. Lu wrote: > On Fri, Jan 23, 2015 at 3:13 PM, Chris Metcalf wrote: >> On 1/23/2015 5:03 PM, H.J. Lu wrote: >>> >>> On Fri, Jan 23, 2015 at 1:32 PM, Carlos O'Donell >>> wrote: >>>> >>>> Dear Machine Maintainers, >>>> >>>> Please start testing your machines against glibc >>>> master. >>>> >>>> Please update the glibc 2.21 release page with your >>>> testing results: >>>> >>>> https://sourceware.org/glibc/wiki/Release/2.21 >>>> >>>> If nobody objects I want to cut the release as soon >>> >>> x32 failed to build: >>> >>> https://sourceware.org/bugzilla/show_bug.cgi?id=17870 >> >> >> tilegx32 failed to build with the same symptoms. >> > > I checked in my fix. It should build for you now. > I checked in another fix. diff --git a/ChangeLog b/ChangeLog index a59266f..306341c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,7 @@ with uint64_t. * nptl/sem_waitcommon.c (__sem_wait_cleanup): Replace 1UL with (uint64_t) 1. + (__new_sem_wait_fast): Replace unsigned long with uint64_t. (__new_sem_wait_slow): Replace unsigned long int with uint64_t. Replace 1UL with (uint64_t) 1. * sysdeps/nptl/internaltypes.h (new_sem): Replace unsigned long diff --git a/nptl/sem_waitcommon.c b/nptl/sem_waitcommon.c index c60daa3..311e511 100644 --- a/nptl/sem_waitcommon.c +++ b/nptl/sem_waitcommon.c @@ -228,7 +228,7 @@ __new_sem_wait_fast (struct new_sem *sem, int definitive_result) and the failure path of the CAS. If the weak CAS fails and we need a definitive result, retry. */ #if __HAVE_64B_ATOMICS - unsigned long d = atomic_load_relaxed (&sem->data); + uint64_t d = atomic_load_relaxed (&sem->data); do {