From patchwork Fri Jun 19 11:06:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Senkevich X-Patchwork-Id: 486665 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 06A951401F0 for ; Fri, 19 Jun 2015 21:07:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sourceware.org header.i=@sourceware.org header.b=u4Dwkd4y; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=l1J7 ben92ftkFK7Dsp8cAZl3AIc7Xyy92/bNLGSjndPhClKNHdefNXXKnsmQmeLAKUqE wO5elxdR/OMac1l20AXu6Yyb4AOVGteCRcXKtCLOJ8i5Ve7v57x449f4qtyAfW9g 0vYB2nV5L3kTPNrz0+mrxAh71aedvWZ7pTALLnE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=Y9dUX1F80L WPh7Na7YK5exhLpL4=; b=u4Dwkd4yPqXRIGdVE6GZxH37BxnBzv+GMfPlU46Ky8 DGphQKK005BwvMQvOHkgXBsNOB15oyvJuSMwrKEsvdChAdIqIC8GslHvDWXLEmPn 1xzBe9ITmm5x72FD3yblB421AVCJzb4uvGMElDT8FQitZtlQ9wxjIs8BX7JSWk/E s= Received: (qmail 79330 invoked by alias); 19 Jun 2015 11:07:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 79313 invoked by uid 89); 19 Jun 2015 11:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_40, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f181.google.com X-Received: by 10.152.29.6 with SMTP id f6mr16872823lah.85.1434712046034; Fri, 19 Jun 2015 04:07:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150619075546.4284b164@kryten> References: <20150619075546.4284b164@kryten> From: Andrew Senkevich Date: Fri, 19 Jun 2015 14:06:55 +0300 Message-ID: Subject: Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests) To: "Joseph S. Myers" Cc: libc-alpha , sjmunroe@us.ibm.com, tuliom@linux.vnet.ibm.com, Anton Blanchard 2015-06-19 0:55 GMT+03:00 Anton Blanchard : > Hi Andrew, > >> here is implementation of vectorized sincos containing SSE, AVX, >> AVX2 and AVX512 versions according to Vector ABI >> . > > This breaks powerpc64 builds, in sysdeps/ieee754/ldbl-opt/s_sin.c: > > #define sincos sincos_disable > > Which means we end up with: > > __DECL_SIMD_sincos_disable extern void sincos_disable (double __x, > double *__sinx, double *__cosx) __attribute__ ((__nothrow__ )); extern void __sincos_disable (double __x, double *__sinx, double *__cosx) __attribute__ ((__nothrow__ )) > ; > Regards, > Anton Proposal is fix it so: Ok? --- WBR, Andrew diff --git a/bits/libm-simd-decl-stubs.h b/bits/libm-simd-decl-stubs.h index ec1fa69..6d0558a 100644 --- a/bits/libm-simd-decl-stubs.h +++ b/bits/libm-simd-decl-stubs.h @@ -45,6 +45,10 @@ #define __DECL_SIMD_sincosf #define __DECL_SIMD_sincosl +/* This is needed because of definition of sincos + in sysdeps/ieee754/ldbl-opt/s_sin.c. */ +# define __DECL_SIMD_sincos_disable + #define __DECL_SIMD_log #define __DECL_SIMD_logf #define __DECL_SIMD_logl