diff mbox series

[3/4] nss: Fix incorrect switch fall-through in tst-nss-gai-actions

Message ID 8f5c9665df60b69a45673bb22309f597ec4eb719.1722604821.git.fweimer@redhat.com
State New
Headers show
Series Turn on -Wimplicit-fallthrough | expand

Commit Message

Florian Weimer Aug. 2, 2024, 1:22 p.m. UTC 
This only happened on test failure.
---
 nss/tst-nss-gai-actions.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Adhemerval Zanella Aug. 6, 2024, 6:47 p.m. UTC | #1 
On 02/08/24 10:22, Florian Weimer wrote:
> This only happened on test failure.


LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  nss/tst-nss-gai-actions.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/nss/tst-nss-gai-actions.c b/nss/tst-nss-gai-actions.c
> index efca6cd183..e42bbd6cae 100644
> --- a/nss/tst-nss-gai-actions.c
> +++ b/nss/tst-nss-gai-actions.c
> @@ -92,6 +92,7 @@ do_one_test (int action, int family, bool canon)
>  	  printf ("merge unexpectedly succeeded:\n %s\n", formatted);
>  	  support_record_failure ();
>  	  free (formatted);
> +	  break;
>  	}
>        else
>  	return;
diff mbox series

Patch

diff --git a/nss/tst-nss-gai-actions.c b/nss/tst-nss-gai-actions.c
index efca6cd183..e42bbd6cae 100644
--- a/nss/tst-nss-gai-actions.c
+++ b/nss/tst-nss-gai-actions.c
@@ -92,6 +92,7 @@  do_one_test (int action, int family, bool canon)
 	  printf ("merge unexpectedly succeeded:\n %s\n", formatted);
 	  support_record_failure ();
 	  free (formatted);
+	  break;
 	}
       else
 	return;