Message ID | 6e50c64-98e6-7cbf-52be-c0167eb2dd9@codesourcery.com |
---|---|
State | New |
Headers | show |
Series | Remove MAP_VARIABLE from hppa bits/mman.h | expand |
Ping. This patch <https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is pending review.
Ping^2. This patch <https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is still pending review.
On 5/17/23 16:38, Joseph Myers wrote: > As suggested in > <https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>, > remove the MAP_VARIABLE define from the hppa bits/mman.h, for > consistency with Linux 6.2 which removed the define there. > > Tested with build-many-glibcs.py for hppa-linux-gnu. > > diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h > index f5a69693af..651b7dcb72 100644 > --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h > +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h > @@ -24,7 +24,6 @@ > > /* Other flags. */ > #define __MAP_ANONYMOUS 0x10 /* Don't use a file */ > -#define MAP_VARIABLE 0 > > /* These are Linux-specific. */ > #define MAP_DENYWRITE 0x0800 /* ETXTBSY */ > LGTM. Reviewed Linux at commit 933174ae28ba72ab8de5b35cb7c98fc211235096 (6.4.0-rc3) and there is no more references to MAP_VARIABLE. The references are removed as of 71bdea6f798b425bc0003780b13e3fdecb16a010 and are no longer in the UAPI mman.h headers. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h index f5a69693af..651b7dcb72 100644 --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h @@ -24,7 +24,6 @@ /* Other flags. */ #define __MAP_ANONYMOUS 0x10 /* Don't use a file */ -#define MAP_VARIABLE 0 /* These are Linux-specific. */ #define MAP_DENYWRITE 0x0800 /* ETXTBSY */