From patchwork Fri Aug 2 13:22:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1968362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ceunL20l; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Wb62L175Pz1yZl for ; Fri, 2 Aug 2024 23:22:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5BC2B3858D3C for ; Fri, 2 Aug 2024 13:22:32 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 551413858D20 for ; Fri, 2 Aug 2024 13:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 551413858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 551413858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722604935; cv=none; b=KBQkX0/dgs3ye+HU/Cf8jPjmxZrTbj9mrpfajRate0N6LX+QEalUFhTHW3zugDwV5p2lJOf+NO3NQNO9KNp8DrG7hNMwv2qFnwOUaxhJ7uzQmQZAPZS6z8vz8zKOETq1WDjwJoQfBdCcZnqoYSK7vzQGKC0zr5vYqP9Ei7W92xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722604935; c=relaxed/simple; bh=SNLETudFbWC0UET2Gz762RUmh998eH4VcUiLPU1EkfY=; h=DKIM-Signature:From:To:Subject:Message-ID:Date:MIME-Version; b=OgRI5PDnjRJWQ4ypVIZYjCq0CMBOgpCoVyz/SYc7lERbDdkg7VCIZBJXDYtNxC4LV8O9v7N6lOcAKOzIoSfVfFV5fNVpqHmus3Mz+8W81SKPnr2i1ojZxov62okC3VdQfgz/JN3vfD6tJs20/aQEq3RLRd4v4pNCNt3ub0FAUes= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722604934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qSMbvcWNcxG3iD67J6GXZh5Ihvo1Btcz8A+kfWcmmlk=; b=ceunL20liwCr/Ru82dMRXl/xVK767ORJy903xLJPGEBWoR1VFEIX/Y/qvIUX3GhCrmDBdB RfToYZvkHKqykWeZ8J/LgQblFNNCGUSJ10NK3gCtNFKtYhYKb5D8Cf6WU2Vw/CfGAw6lGm Vewq4Jv76M08qTI6D0+iahcDYCaapQc= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-SwthmBxnPe6UTOXNYx_4lA-1; Fri, 02 Aug 2024 09:22:12 -0400 X-MC-Unique: SwthmBxnPe6UTOXNYx_4lA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA0351955D55 for ; Fri, 2 Aug 2024 13:22:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.45.224.139]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E759819560AE for ; Fri, 2 Aug 2024 13:22:10 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH 1/4] x86: Add missing switch/case fall-through markers to init_cpu_features In-Reply-To: Message-ID: <6604c632eeb87200dc58d36086bdd044b69e11f3.1722604821.git.fweimer@redhat.com> References: X-From-Line: 6604c632eeb87200dc58d36086bdd044b69e11f3 Mon Sep 17 00:00:00 2001 Date: Fri, 02 Aug 2024 15:22:07 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org The commits introducing these fall-throughs intended them to happen. Reviewed-by: Noah Goldstein --- sysdeps/x86/cpu-features.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c index c096dd390a..18ed008040 100644 --- a/sysdeps/x86/cpu-features.c +++ b/sysdeps/x86/cpu-features.c @@ -879,6 +879,7 @@ init_cpu_features (struct cpu_features *cpu_features) non-temporal on all Skylake servers. */ cpu_features->preferred[index_arch_Avoid_Non_Temporal_Memset] |= bit_arch_Avoid_Non_Temporal_Memset; + /* fallthrough */ case INTEL_BIGCORE_COMETLAKE: case INTEL_BIGCORE_SKYLAKE: case INTEL_BIGCORE_KABYLAKE: @@ -1073,6 +1074,7 @@ https://www.intel.com/content/www/us/en/support/articles/000059422/processors.ht /* Yongfeng and Shijidadao mircoarch tuning. */ case 0x5b: cpu_features->cachesize_non_temporal_divisor = 2; + /* fallthrough */ case 0x6b: cpu_features->preferred[index_arch_AVX_Fast_Unaligned_Load] &= ~bit_arch_AVX_Fast_Unaligned_Load;