| Message ID | 619b0777-063a-5fd9-9a61-8c387c4d3dc7@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Increase timeout of nss/tst-nss-files-hosts-multi | expand |
On 10/9/18 10:20 AM, Szabolcs Nagy wrote: > Increase timeout from the default 20s to 40s. This test makes close to > 2 million syscalls with distribution: > > 1180249 connect > 297952 getsockname > 144040 lseek > 143734 read > 14466 close > ... > > connect can be slow, so the default timeout was not enough on slow > systems. > > 2018-10-09 Szabolcs Nagy <szabolcs.nagy@arm.com> > > * nss/tst-nss-files-hosts-multi.c (TIMEOUT): Define. > OK for master. Here it's plausible that this test does timeout, but 40s is fine for normal testing. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Thank you for these patches, Szabolcs. I experience more tests always failing due to timeouts on one machine. Unfortunately, they are different tests than those which you have fixed. But I will take your work as an example and investigate what timeout values should be to satisfy tests on this particular machine. The tests currently failing for me due to timeouts are: FAIL: nptl/tst-robust-fork FAIL: nss/tst-nss-files-hosts-getent FAIL: stdlib/test-bz22786 FAIL: timezone/tst-tzset Regards, Rafal
diff --git a/nss/tst-nss-files-hosts-multi.c b/nss/tst-nss-files-hosts-multi.c index a4edb3c036..21f678d93f 100644 --- a/nss/tst-nss-files-hosts-multi.c +++ b/nss/tst-nss-files-hosts-multi.c @@ -327,5 +327,6 @@ do_test (void) return 0; } +#define TIMEOUT 40 #define PREPARE prepare #include <support/test-driver.c>