From patchwork Mon Aug 17 15:28:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Weinberg X-Patchwork-Id: 508003 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3827C140293 for ; Tue, 18 Aug 2015 01:28:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=wnm99R++; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type; q=dns; s=default; b=VzDC N3DaaANrkFslYb4IKMUZk66kIcY3oNI7JFavFSQjWUc/hvlca8q6MykC/z22tlCR pu7WInziNCbMZRt2ZKlG4YGc4x5lBp3jSAKWtLcNSjO7j02VBF3Y2lidrC0VR6C0 Ghln5KKNRgf98JYrf9ioryZWFjxHW6es5KKWF0w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type; s=default; bh=x6/9vZn8mg qX/2EGQRpsjCinOF4=; b=wnm99R++eXBRjxvaR5ZDGShrIiBajYsXhCZywtg6gG HLYEvgzPm+jD9fVZRu7LbMxJvyAg1aw4SvkK0NNT5BeZ7Bi2aIAVvcxX69dXWOD+ SfAwGifhA9cPJXysn2B3wIwW/8PVznvm1hBDr1xWbKOok39mxkfzgypQrSw7q9ts M= Received: (qmail 29646 invoked by alias); 17 Aug 2015 15:28:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 29635 invoked by uid 89); 17 Aug 2015 15:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type; bh=V+eLENtSGbgihIySBLFyU5XHdNXoNDFX1uMRefo0RfI=; b=RhJNiogHYYfOJnNlP5T/1Dsh9QTpcZS3Ek+nMXcIe/Fk1wEO8yPCL5W8rLKMj52XWP B+KsGKwXOJUq4PVmCf3a/oLCIc+MWKBSDIRmfM4BWkwfdBEkldeN+x6BNfStqMJHRkZE 6wMWtqkOLjK533PuNsDpu1h2Ov4SIP56itoSvb53hXCW8vYbOj3I1KNiigd5nJRZiEBT bwLL/ozWh/KF0hiW/Com0pNbS8PF8sx8vxeMT7XX4QANlDdkkyqNB/JlAHrnCTqgArdt bbr0wgQrILkPdCX+XJ1YcRkzcWJXkQD0Y4j8otw3VqdOrxQNj/GJ/NPZ3iWlMTiKpE4W U+9g== X-Received: by 10.129.136.67 with SMTP id y64mr1890617ywf.33.1439825328416; Mon, 17 Aug 2015 08:28:48 -0700 (PDT) Subject: Re: [2.23 PATCH] Desupport regexp.h (bug 18681) To: Andreas Schwab References: <20150805152109.2FDA114B9A@panix1.panix.com> <55D1E207.30203@panix.com> <20150817135629.GE1584@vapier> Cc: GNU C Library From: Zack Weinberg Message-ID: <55D1FDAE.6000000@panix.com> Date: Mon, 17 Aug 2015 11:28:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: On Mon, Aug 17, 2015 at 11:08 AM, Zack Weinberg wrote: > Just now I did this again and also ran `git clean -dxf` in the source > tree (which deleted only editor backups) and -- this is a little weird > -- it compiles without complaint, but the VERSION_libc_GLIBC_2_xx > #defines in abi-versions.h only go up to 2_22. I take that back. I *am* getting the same warning as Stefan, it just didn't cause a build failure and scrolled off the top of my terminal. The misc/Versions change suggested by Mike does cure the problem, so here is a properly formatted patch. zw * misc/Versions: Add empty GLIBC_2.23 stanza, to prevent undefined macro warnings in regexp.c. --- misc/Versions | 3 +++ 1 file changed, 3 insertions(+) diff --git a/misc/Versions b/misc/Versions index 534d1a3..671f487 100644 --- a/misc/Versions +++ b/misc/Versions @@ -149,6 +149,9 @@ libc { GLIBC_2.16 { __getauxval; getauxval; } + GLIBC_2.23 { + # SHLIB_COMPAT(GLIBC_2_0, GLIBC_2_23) used in regexp.c + } GLIBC_PRIVATE { __madvise; __mktemp; -- 2.5.0