From patchwork Wed Jul 8 08:55:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 492766 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 922771402AA for ; Wed, 8 Jul 2015 18:55:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=gQNPTyjj; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=EhKHwUaJRcAI+Vy3 j48FN4ApVkCh868gYWfTJH3OVk6WudrTVWquVktPQQVJT++eNgb30iu43r2WORmz En6tH3OPFkbqauMQDsUsDszZFEuPZXYVZQSLmrKLIH/o+6+Jeoe725xH3EUg32yk KNs5qriiVB0qxIjLP3+wX7RmsUI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=iAPkP5e84w4965YsolJuB8 M4QN8=; b=gQNPTyjj6Mky/it7psPDxVDGbe/z/iTARc+1IQqz04Ft7TXnPvL1Di J7XzxZYuD0k0FMI/KBKwzMCR77qL4IsY0cpvUACblQfluKA5F9Vw99DxH5XB/8vh LWC4qKmAbNDWWzZ48twxynC0c/Edw1OoYqe7GpF0J+8/ujs84Uhyc= Received: (qmail 32031 invoked by alias); 8 Jul 2015 08:55:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 31547 invoked by uid 89); 8 Jul 2015 08:55:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <559CE58A.90706@redhat.com> Date: Wed, 08 Jul 2015 04:55:38 -0400 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Feng Gao , Siddhesh Poyarekar CC: libc-alpha@sourceware.org Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags References: <20150707073145.GK13549@spoyarek.pnq.redhat.com> <20150707162858.GR13549@spoyarek.pnq.redhat.com> In-Reply-To: On 07/08/2015 02:15 AM, Feng Gao wrote: > It stop the following step for about 2 hours, so I have to cancel it. > > scripts/evaluate-test.sh c++-types-check $? false false > > /home/fgao/works/my_git_codes/glibc-build/c++-types-check.test-result > AWK='gawk' scripts/check-local-headers.sh \ > "/usr/include" "/home/fgao/works/my_git_codes/glibc-build/" >> /home/fgao/works/my_git_codes/glibc-build/check-local-headers.out; \ > scripts/evaluate-test.sh check-local-headers $? false false > > /home/fgao/works/my_git_codes/glibc-build/check-local-headers.test-result This is a super annoying failure mode that happens when `make` fails or is not run. The fix is as follows, and I'll check it in shortly. 2015-07-08 Carlos O'Donell * Makefile ($(objpfx)check-local-headers.out): Redirect input from /dev/null. --- c. diff --git a/Makefile b/Makefile index 658ccfa..c88b2e5 100644 --- a/Makefile +++ b/Makefile @@ -262,7 +262,7 @@ endif $(objpfx)check-local-headers.out: scripts/check-local-headers.sh AWK='$(AWK)' scripts/check-local-headers.sh \ - "$(includedir)" "$(objpfx)" > $@; \ + "$(includedir)" "$(objpfx)" < /dev/null > $@; \ $(evaluate-test) ifneq ($(PERL),no)