From patchwork Sun May 25 22:30:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 352308 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C9F2514008A for ; Mon, 26 May 2014 08:31:19 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=KeY5+D/lD5wq0/KU 6f7YgpDZcSyTWiiUz/OTL9HIJrvLzY3oXo9FiocJ00ICn7cLE6xYBOeRuTrbFTHW kAmnTyrn15u0qKE1OySbO/sUgZABlRZU+M0cW+YfBfG9mC/duw7jvXt0b5qU0nYo QMIWlpPVo00sSn3T1TkeeuXTp14= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=5Ixd+FFfTlmTgrCMra0phQ DFyAc=; b=CK3wSP8gaAVtgL+JaPXfFIWvYqmVEbvH3tMM9iXOHf8VdY29zMF9tY SrvHdu3fRVRm8D7xWxR3V0vyat7k/ufltKNpEdnDxfw+g7Fgd1c2385+gABbGy4S PSjl946ofP9NVLCirx19t1x6fckZDRhCjIZ763S5s9iNC2XuIaZYg= Received: (qmail 3914 invoked by alias); 25 May 2014 22:31:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3902 invoked by uid 89); 25 May 2014 22:31:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp02.br.ibm.com Message-ID: <53826F20.4050303@linux.vnet.ibm.com> Date: Sun, 25 May 2014 19:30:56 -0300 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Roland McGrath CC: "GNU C. Library" Subject: Re: [PATCH 5/5] PowerPC: Move remaining, nptl/sysdeps/unix/sysv/linux/powerpc/ files. References: <537F4CC7.6040202@linux.vnet.ibm.com> <20140523220615.5E66B2C3B74@topped-with-meat.com> In-Reply-To: <20140523220615.5E66B2C3B74@topped-with-meat.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14052522-2194-0000-0000-000008E88EF0 On 23-05-2014 19:06, Roland McGrath wrote: > When you are posting a change that is largely verbatim file moves, and > especially if you aren't expecting people to apply the patch themselves > with 'patch' (because you supplied a git branch, or because you advise > people they'll have to use 'git apply'), using 'git diff --renames' makes > the diff a lot easier to review. Thanks for tip, I'll use later. > >> * nptl/sysdeps/unix/sysv/linux/powerpc/Makefile: Moved ... >> * sysdeps/unix/sysv/linux/powerpc/nptl/Makefile: ... here. > Not helpful. At the end of the day, there should not be a > sysdeps/unix/sysv/linux/powerpc/nptl/ subdirectory at all. You need to > merge the nptl/.../Makefile contents into the existing > sysdeps/unix/sysv/linux/powerpc/Makefile instead. Note that they > really should have an 'ifeq ($(subdir),nptl)' conditional that the > old Makefile was missing. Indeed, thanks for spotting it. I'll update the patch with this modification to remove sysdep/.../nptl/Makefile > The rest looks fine off hand. > > > Thanks, > Roland > diff --git a/sysdeps/unix/sysv/linux/powerpc/Makefile b/sysdeps/unix/sysv/linux/powerpc/Makefile index 395342f..28f7165 100644 --- a/sysdeps/unix/sysv/linux/powerpc/Makefile +++ b/sysdeps/unix/sysv/linux/powerpc/Makefile @@ -31,3 +31,7 @@ sysdep_headers += bits/ppc.h sysdep_routines += get_timebase_freq tests += test-gettimebasefreq endif + +ifeq ($(subdir),nptl) +libpthread-routines += sysdep +endif diff --git a/sysdeps/unix/sysv/linux/powerpc/nptl/Makefile b/sysdeps/unix/sysv/linux/powerpc/nptl/Makefile deleted file mode 100644 index e98c9bd..0000000 --- a/sysdeps/unix/sysv/linux/powerpc/nptl/Makefile +++ /dev/null @@ -1,2 +0,0 @@ -# pull in __syscall_error routine -libpthread-routines += sysdep