Message ID | 5362DA44.3090507@redhat.com |
---|---|
State | New |
Headers | show |
That looks fine.
On 05/01/2014 07:35 PM, Carlos O'Donell wrote: > 2014-05-01 Carlos O'Donell <carlos@redhat.com> > > * sysdeps/x86_64/multiarch/init-arch.h: Define FEATURE_INDEX_1 to 0. > [!__ASSEMBLER__]: Remove anonymous enum for FEATURE_INDEX_*. Fixed. commit 8f1df5cf9d8d30c0747532301dca3cf9c99fbc8e Author: Carlos O'Donell <carlos@redhat.com> Date: Sat May 3 00:25:21 2014 -0400 Fix -Wundef warning for FEATURE_INDEX_1. Define FEATURE_INDEX_1 and FEATURE_INDEX_MAX as macros for use by both assembly and C code. This fixes the -Wundef error for cases where FEATURE_INDEX_1 was not defined but used the correct value of 0 for an undefined macro. Cheers, Carlos.
diff --git a/sysdeps/x86_64/multiarch/init-arch.h b/sysdeps/x86_64/multiarch/init-arch.h index 813b6de..e4d265d 100644 --- a/sysdeps/x86_64/multiarch/init-arch.h +++ b/sysdeps/x86_64/multiarch/init-arch.h @@ -47,6 +47,12 @@ #define bit_XMM_state (1 << 1) #define bit_YMM_state (2 << 1) +/* The integer bit array index for the first set of internal feature bits. */ +# define FEATURE_INDEX_1 0 + +/* The current maximum size of the feature integer bit array. */ +# define FEATURE_INDEX_MAX 1 + #ifdef __ASSEMBLER__ # include <ifunc-defines.h> @@ -82,13 +88,6 @@ enum COMMON_CPUID_INDEX_MAX }; -enum - { - FEATURE_INDEX_1 = 0, - /* Keep the following line at the end. */ - FEATURE_INDEX_MAX - }; - extern struct cpu_features { enum cpu_features_kind