diff mbox

Correct minimal test suite changes for elision enabled kernels.

Message ID 533E9CF2.8030306@linux.vnet.ibm.com
State New
Headers show

Commit Message

Stefan Liebler April 4, 2014, 11:52 a.m. UTC 
Hi,

according to the comment in
"Re: [PATCH 03/14] Add minimal test suite changes for elision enabled 
kernels"
(https://www.sourceware.org/ml/libc-alpha/2013-06/msg01145.html),
the tests tst-mutex5/8 are changed in order to not check some behaviour 
of POSIX if lock elision is enabled at configure time.
Currently, the timeout of pthread_mutex_timedlock is only tested
with elision enabled at configure time and not for the default case.

Bye

---
2014-04-04  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* nptl/tst-mutex5 (do_test):
	Use #ifndef ENABLE_LOCK_ELISION instead of #ifdef.
---

Comments

Ondřej Bílka May 18, 2014, 10:49 a.m. UTC | #1 
On Fri, Apr 04, 2014 at 01:52:18PM +0200, Stefan Liebler wrote:
> Hi,
> 
> according to the comment in
> "Re: [PATCH 03/14] Add minimal test suite changes for elision enabled 
> kernels"
> (https://www.sourceware.org/ml/libc-alpha/2013-06/msg01145.html),
> the tests tst-mutex5/8 are changed in order to not check some behaviour 
> of POSIX if lock elision is enabled at configure time.
> Currently, the timeout of pthread_mutex_timedlock is only tested
> with elision enabled at configure time and not for the default case.
> 
Looks like typo as rest changes use ifndef. I am ok with this.
diff mbox

Patch

diff --git a/nptl/tst-mutex5.c b/nptl/tst-mutex5.c
index 14d3025..a829272 100644
--- a/nptl/tst-mutex5.c
+++ b/nptl/tst-mutex5.c
@@ -87,7 +87,7 @@  do_test (void)
     }
 
   /* Elided locks do not time out.  */
-#ifdef ENABLE_LOCK_ELISION
+#ifndef ENABLE_LOCK_ELISION
   if (pthread_mutex_trylock (&m) == 0)
     {
       puts ("mutex_trylock succeeded");