From patchwork Wed Jan 16 21:10:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 1026223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-99343-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="aR7tPEPp"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43g0Hx35G0z9sBn for ; Thu, 17 Jan 2019 08:11:24 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:cc:from:to:subject:message-id:date :mime-version:content-type:content-transfer-encoding; q=dns; s= default; b=GsTlJH0EFt+BLLj/DULlTYQiIfQv6P7mkS98jNq8JGf/O4x69RwJj MvV9Wfmrw00iZLDHZSWOVcO5kdgT0WVTbRs+ZQ+OjwMtx0nm2O08/Cq4lB15fbjt w2ST10epAvD/vcAqMUuQiu3a0kKV2f+mJMpuONw7PLKboxlrxhAK50= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:cc:from:to:subject:message-id:date :mime-version:content-type:content-transfer-encoding; s=default; bh=eqNxmTlLpOTODtAWiRRf82shWTU=; b=aR7tPEPp1JVq2t1mLEgjcnAuwncY 3lGey7RNcqkX9Vqry8eJxeRRYdMhpkIzVRh0Yue3n+TrOmmIqR5peekMtEq+KvNX 5GARijkpPKVcWfY+ePmFhjuRBskS4pR4bG9KM4ych24eAtdqNRwcW8iSjdOpeHLP M31FGsqMub0VL7M= Received: (qmail 19708 invoked by alias); 16 Jan 2019 21:11:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 19483 invoked by uid 89); 16 Jan 2019 21:11:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=shame X-HELO: mail-qt1-f194.google.com Cc: Florian Weimer , DJ Delorie , Arjun Shankar From: Carlos O'Donell Openpgp: preference=signencrypt To: GNU C Library Subject: Failing misc/check-installed-headers-c with new kernel headers. Message-ID: <30a12210-dbcc-f92f-ad59-2b1c5ad10136@redhat.com> Date: Wed, 16 Jan 2019 16:10:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In the latest Fedora Rawhide weekly glibc rebase I'm seeing a failure across all arches. This: BUILDSTDERR: FAIL: misc/check-installed-headers-c With this specific output: BUILDSTDERR: :: sys/sysctl.h BUILDSTDERR: :::: BUILDSTDERR: *** Obsolete types detected: BUILDSTDERR: /usr/include/linux/sysctl.h: KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */ BUILDSTDERR: :::: -D_DEFAULT_SOURCE=1 BUILDSTDERR: :::: -D_GNU_SOURCE=1 BUILDSTDERR: :::: -D_XOPEN_SOURCE=700 BUILDSTDERR: :::: -std=c89 BUILDSTDERR: :::: -std=c89 -D_DEFAULT_SOURCE=1 BUILDSTDERR: :::: -std=c89 -D_GNU_SOURCE=1 BUILDSTDERR: :::: -std=c89 -D_XOPEN_SOURCE=700 BUILDSTDERR: :::: -std=gnu89 BUILDSTDERR: :::: -std=gnu89 -D_DEFAULT_SOURCE=1 BUILDSTDERR: :::: -std=gnu89 -D_GNU_SOURCE=1 BUILDSTDERR: :::: -std=gnu89 -D_XOPEN_SOURCE=700 BUILDSTDERR: :::: -std=c11 BUILDSTDERR: :::: -std=c11 -D_DEFAULT_SOURCE=1 BUILDSTDERR: :::: -std=c11 -D_GNU_SOURCE=1 BUILDSTDERR: :::: -std=c11 -D_XOPEN_SOURCE=700 BUILDSTDERR: :::: -std=gnu11 BUILDSTDERR: :::: -std=gnu11 -D_DEFAULT_SOURCE=1 BUILDSTDERR: :::: -std=gnu11 -D_GNU_SOURCE=1 BUILDSTDERR: :::: -std=gnu11 -D_XOPEN_SOURCE=700 This is a false positive from the regexp used to search for obsolete types. Commit 81c9d43f94870 is the upstream kernel commit that triggers this: --- Thoughts? diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h index d71013fffaf6..87aa2a6d9125 100644 --- a/include/uapi/linux/sysctl.h +++ b/include/uapi/linux/sysctl.h @@ -153,6 +153,7 @@ enum KERN_NMI_WATCHDOG=75, /* int: enable/disable nmi watchdog */ KERN_PANIC_ON_NMI=76, /* int: whether we will panic on an unrecovered */ KERN_PANIC_ON_WARN=77, /* int: call panic() in WARN() functions */ + KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */ }; --- The obsolete type is shorthand in a comment. Should we expand the regexp in some way to ignore text within single-line comments that we can easily detect? Or is the accepted fix something like this (untested)? Seems a shame not to check sysctl.h. However use of legacy types seem fairly rare these days. diff --git a/scripts/check-installed-headers.sh b/scripts/check-installed-headers.sh index 8e7beffd82..1742c2bf20 100644 --- a/scripts/check-installed-headers.sh +++ b/scripts/check-installed-headers.sh @@ -127,6 +127,12 @@ EOF ;; esac ;; + + # linux/sysctl.h is unsupported for all arches because it contains + # a comment with 'ulong' as shorthand for a type. + (sys/sysctl.h) + continue;; + esac echo :: "$header"