From patchwork Fri Oct 25 07:45:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arjun Shankar X-Patchwork-Id: 2002035 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eMItcMbi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XZZhK2B8Hz1xtp for ; Fri, 25 Oct 2024 18:50:25 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C8153858D35 for ; Fri, 25 Oct 2024 07:50:23 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 390E93858D21 for ; Fri, 25 Oct 2024 07:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 390E93858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 390E93858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729842609; cv=none; b=sHNq1QaZPCmXsSgqdHQNRgFGGYOPzQjj+C3Gd6dW4Gw98/Ld++jy3pJ/mGfJn7Rff0GUgbkqPHpXGrPi4M9LK1WOY9sTzRroJh3ztpCDXl68oNxaBK+EuTAGj+62qFDcqF0nakYJotncK3Ds8RoELHxwk3jrFBSXWhtnkA3/QVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729842609; c=relaxed/simple; bh=uELA5Ju02+wWhg0TE8scthaxa32rDeGkgsR4VJoGhCI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QPHbmQKt2lNdinG59Bj+H//sSE/Ver6T70pAUucOnYj7fDlSlKlg0Ohz2Rwf7CnnQ+Kr0X9PMbycneHGpRwx2vu1MBZaF+tpe8H0T67ZqQwJWHKxt164ZRy7QGUXHGuwwQ2EeZNGW9O4Zt/2XdlfUEDGVjrl+3QT3ZIj2RgTIq0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729842602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=43/PftYQG8kmJmSuB6yODSTpBg2ftP6ATpc429R3qEs=; b=eMItcMbihuAkkc0ytU8bstQ1ukUzMUlm2edpV/X9KCki+IW+nrUoa8l6x4JJzokuRPoPr+ 4ARsnCNQAOzU9gd0VGgmC7IVhPXkR2JrGGsdxqUf1Ox3SavQuUiPQIntHglQKtrhT9ec3a 57EsSZFKe8muGZ8rxVuOTjDkIZ4C0Ys= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-1ajh3jgqPemqKTiRHl-zQg-1; Fri, 25 Oct 2024 03:50:01 -0400 X-MC-Unique: 1ajh3jgqPemqKTiRHl-zQg-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 885101955F56 for ; Fri, 25 Oct 2024 07:50:00 +0000 (UTC) Received: from x1carbon9g.redhat.com (unknown [10.45.224.2]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5B4019560A2; Fri, 25 Oct 2024 07:49:58 +0000 (UTC) From: Arjun Shankar To: libc-alpha@sourceware.org Cc: Joseph Myers , Florian Weimer Subject: [PATCH v2] libio: Correctly link tst-popen-fork against libpthread Date: Fri, 25 Oct 2024 09:45:30 +0200 Message-ID: <20241025074951.1932806-1-arjun@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org tst-popen-fork failed to build for Hurd due to not being linked with libpthread. This commit fixes that. Tested with build-many-glibcs.py for i686-gnu. Reviewed-by: Florian Weimer --- v1 here: https://sourceware.org/pipermail/libc-alpha/2024-October/160928.html Changes in v2: Removed unnecessary check for have-thread-library. libio/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libio/Makefile b/libio/Makefile index 018c26d971..cd5a3afeeb 100644 --- a/libio/Makefile +++ b/libio/Makefile @@ -144,6 +144,8 @@ tests = \ tst_wscanf \ # tests +$(objpfx)tst-popen-fork: $(shared-thread-library) + tests-internal = tst-vtables tst-vtables-interposed ifeq (yes,$(build-shared))